Re: MipmapTexture bug (Patch)

[Frank C <li...@si...>]

Below is a message I attempted to send to the list but apparently the  
attachments were too big - the files can be downloaded here:  
<http://webhome.idirect.com/~frankco/IRTexture.zip>

Original message follows...

On 5-Jun-04, at 9:14 PM, Stefan Huber wrote:

> In ir_texture_convert_rave_filter the GL filter values has been  
> changed a few days ago. I've found a message about incomplete mipmap  
> specifications:  
> http://lists.apple.com/archives/mac-opengl/2003/Oct/13/ 
> ilosttextureunit2.001.txt. It says that CMF apps handle these cases as  
> linear where Mach-0 apps handle these cases as failure.

I've attached two patched files that should fix this issue. The patch  
adds a "useMipmapping" flag to cached textures that allows  
ir_texture_set_state to fall back to the mag filter for the  
minification setting when textures lack mipmaps.

NOTE: This won't catch cases where a Mipmap texture contains a partial  
set, so you'll either have to guarantee a full set, or ensure that the  
Mipmap texture's useMipmapping flag is set to false.  
ir_texture_convert_mipmap expects the same, so this seemed reasonable  
(partial sets would certainly be a bad idea either way).

Please let me know how it works out - hopefully someone with CVS access  
can review it as well.

Thanks,
Frank.