|
From: Derek K. <de...@bi...> - 2020-04-09 10:22:26
|
Great. PR for 831 is up. I'll try to chip away at others as time allows. https://github.com/Qucs/qucs/pull/1000 If anyone would like to do a video chat to get setup doing QUCS dev and fixing an issue let me know. That's been fairly successful in another group. Felix, So your suggestion is to work off your refactor+qt5 branch as the most recent starting point? Is this the mouseactions issue you're talking about? https://github.com/Qucs/qucs/issues/560#issuecomment-453266519 Cheers, Derek On 08/04/2020 15:19, Felix Salfelder wrote: > On Wed, Apr 08, 2020 at 02:44:03PM +0100, Derek Kozel wrote: >> Hi Felix, >> >> I realize I'm repeating a question already answered on GitHub issues, but >> most of that discussion is over a year old now. >> https://github.com/Qucs/qucs/issues/560 >> >> What branch should we check out and target for Qt5 PRs? Your Qt5 PR is from >> Feb 17, best to target the branch on your repo? Is the list on this PR the >> best place to start looking for things to do? >> https://github.com/Qucs/qucs/pull/898 > Dear Derek. > > I am not currently working on Qucs/Qt5. So the issue I had with > mouseactions is still open, and still the blocker. It is probably worth > looking into #898. If it is any use to you, go ahead rebase and squash > it and plough ahead. There several easier problems, and CMake isn't > working. > > I gave up preparing a sequence of small changes (especially as it got > harder to support both qt4 and 5). If you manage to separate out changes > that can go into develop (look at the early commits) I am happy to > review them -- as time permits. > >> Is it ok to put up PRs targeting develop for non-Qt issues? Or does that >> just take up your time and make the Qt5 work more difficult? >> https://github.com/Qucs/qucs/issues/831 > Non-Qt is possible. If they are not just bugfixes, you might have > difficulties finding a reviewer. #831 (remove buggy res code) looks like > a sensible thing to me. > > cheers > felix > > > _______________________________________________ > Qucs-devel mailing list > Quc...@li... > https://lists.sourceforge.net/lists/listinfo/qucs-devel |