Re: [Qucs-devel] [Qucs] Getting selected Property of a Component

[Kevin V. <kev...@gm...>]

Hi Claudio

I applied the patch (works like a charm!) and have pushed my latest
changes. That should help in my development as well since I was getting
frustrated about the property selection.

I have the feeling selection of properties could benefit from a crosshair
pointer or something similar (like when drawing wires)?

I just checked the Data display remark. Indeed, Qucs-GUI cannot simulate
when started from the data display. I never noticed this before. Probably
because I usually drag my data displays onto the schematic. I think we
should try and find a workaround for this since the whole idea of the tuner
was to see the diagrams change 'live' and it shouldn't matter wheter they
are on their own display or on the schematic.

Regards

Kevin


On Fri, Apr 24, 2015 at 10:25 PM, Claudio Girardi <
cla...@vi...> wrote:

> Hello again...
> I took a look at the code since, as you said, the selection is based on
> existing code and should then work properly; it turns out you did it
> *almost* right, just missed to subtract 1 to an index... Moreover, you were
> a bit unlucky, since the current Qucs code has (had, actually) bug which
> makes the selection of a property with the mouse somewhat imprecise. It was
> corrected only recently, but it is just a single line correction, so I have
> included it in the enclosed patch file. It contains also the correction to
> the property selection for the tuner. You might want to rebase your code to
> the current one, but that is actually not really needed.
> Still, it does not work properly for schematics having a separate Data
> Display, since apparently it tries to generate a netlist for the Data
> Display when this is opened, which obviously does not work, you need to
> manually select the schematic Tab again. Also, some of the updates for the
> min/max values seem not to work correctly sometimes.
> Will maybe take a longer look next week, if you update your code in the
> meantime push it to SF so I can see it.
>
> Regards,
>   Claudio
>
>  ----Messaggio originale----
> Da: kev...@gm...
> Data: 24-apr-2015 18.23
> A: "Claudio Girardi"<cla...@vi...>
> Ogg: Re: [Qucs] Getting selected Property of a Component
>
>
> Hi Claudio
>
> hah, I'm glad you were able to compile and run it.
> I'm having the same issue with the selected properties. Unfortunatly, the
> selection is code is copied from the other Qucs part and I'm kind of
> stumped.
> (Mouse actions; Select, I think...) And i've taken a lot of hints from the
> EditText part of the mouse actions. However I haven't been able to narrow
> the problem down.
>
> I'll don't think I have more at the moment. I'll check. Hopefully I'll
> have some time this weekend to work on it some more.
>
> Regards
> Kevin
>
>
> On Fri, Apr 24, 2015 at 6:18 PM, Claudio Girardi <
> cla...@vi...> wrote:
>
>> Hello Kevin,
>> found just today some time to play with your code. At the beginning I did
>> not understand where/what I should click on :)
>> Now I can get the properties into the Tune dialog (easy, once one
>> knows...) but I cannot get it to run properly. The properties are often
>> picked up wrongly (when I click on a resistor value often it takes the
>> temperature as parameter) and the netlist generated is not valid or empty.
>> Does it work correctly on your side? Which OS are you using? Do you have
>> any update to the code w.r.t. the one you uploaded on Sourceforge?
>>
>> Thanks,
>>   Claudio
>>
>>  ----Messaggio originale----
>> Da: kev...@gm...
>> Data: 11-apr-2015 12.10
>> A:
>> Cc: <quc...@li...>
>> Ogg: Re: [Qucs-devel] Getting selected Property of a Component
>>
>> Hey Claudio
>>
>> forking is done. I've created my own fork + tunerdialogbranch at
>> http://sourceforge.net/u/tipofthesowrd/qucs/ci/tunerdialog/tree/
>> Any logged in user is free to contribute... ;-)
>> Right now cmake is compiling fine. I'll have to check how to get autotools
>> up and running.
>> Thanks for all the help so far
>>
>> Regards
>>
>> Kevin
>>
>> On Sat, Apr 11, 2015 at 11:44 AM, Claudio Girardi <
>> cla...@vi...> wrote:
>>
>> > Hello Kevin,
>> > yodalee created a brief guide on the wiki on this,
>> > https://github.com/Qucs/qucs/wiki/Contribution ; it is quite concise,
>> > feel free to ask if something is not clear.
>> > In general the different branches on the main repository are meant for
>> > long-term, wide-reaching, changes; for smaller changes, which are
>> (supposed
>> > to be) ready to be integrated in to the master branch, you should push
>> your
>> > new branch to your fork on Github and then create a pull request.
>> > Note that we try to keep both the Autotools and cmake build systems
>> > up-to-date, so ideally your new code should be able to be compiled with
>> > both systems; in any case you can create a pull request even if the code
>> > currently builds with the Autotools only, we can figure out later how to
>> > properly compile it with cmake as you can update your local branch and
>> the
>> > related pull request later, before merging it into the master branch.
>> >
>> > Regards,
>> >   Claudio
>> >
>> >  ----Messaggio originale----
>> > Da: kev...@gm...
>> > Data: 11-apr-2015 10.56
>> > A:
>> > Cc: <quc...@li...>
>> > Ogg: Re: [Qucs-devel] Getting selected Property of a Component
>> >
>> > Hi Vadim
>> >
>> > that did it. I had to adjust the Makefile.am file and now everything
>> builds
>> > fine.
>> > I've created a local branch after checking out. What is the best way
>> > forward?
>> > Fork or can I create a seperate branch on the master?
>> >
>> > I'm used to working with mercurial so git is kinda new to me
>> >
>> > Regards,
>> > Kevin
>> >
>> >
>> >
>>
>> ------------------------------------------------------------------------------
>> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>> Develop your own process in accordance with the BPMN 2 standard
>> Learn Process modeling best practices with Bonita BPM through live
>> exercises
>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
>> event?utm_
>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>> _______________________________________________
>> Qucs-devel mailing list
>> Quc...@li...
>> https://lists.sourceforge.net/lists/listinfo/qucs-devel
>>
>>
>>
>
>
>