Menu ▾ ▴

#29 Fix CMake warnings

Unstable_(example)
closed-fixed
nobody
None
5
2017-02-07
2017-02-02
waldyrious
No

Using CMake to build QuaZIP produces two warnings. The changes in this patch fixes them.

Note: this patch was generated with git, since I cloned the repo using git-svn.

1 Attachments
fix-cmake-warnings.patch

Discussion

  • waldyrious

    waldyrious - 2017-02-02

    Actually, I had to make additional fixes to the CMakeLists file, so I'll add a separate patch with all of these:

    • set CMP0042 policy to avoid CMake warning
    • set C++11 standard (without this, the code does not compile)
    • format indentation consistently (change tabs to 4 spaces, as was used in most of the file)
    • format cmake commands consistently (lowercase, and no space before parenthesis, as was used in most of the file)
    • make else() and endif() arguments match the corresponding if(), to avoid CMake warning
     
    fix-cmake-build.patch

  • waldyrious

    waldyrious - 2017-02-02

    Here's the full patched CMakeLists.txt file, in case others want a convenient way to use it locally: https://gist.github.com/waldyrious/ebe9bdb3848399da4cab2b4b8c5627d7

     

  • Sergey A. Tachenov

    Sergey A. Tachenov - 2017-02-04
    • status: open --> closed-fixed
     

  • Sergey A. Tachenov

    Sergey A. Tachenov - 2017-02-04

    Applied in r282.

     

  • waldyrious

    waldyrious - 2017-02-07

    Thanks for the quick reaction. Looking forward to 0.7.3 :)

     

  • Sergey A. Tachenov

    Sergey A. Tachenov - 2017-02-07

    Er? It's already there.

     

  • waldyrious

    waldyrious - 2017-02-07

    Oh, sorry for my distraction, I didn't realize you had made a release.

     

    Last edit: waldyrious 2017-02-07