Update of /cvsroot/quantlibaddin/QuantLibAddin/qlo
In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv3913/qlo
Modified Files:
sequencestatistics.cpp statistics.cpp
Log Message:
"Call empty() instead of checking size()
against zero" -- Scott Mayers "Effective STL", item 4
Index: sequencestatistics.cpp
===================================================================
RCS file: /cvsroot/quantlibaddin/QuantLibAddin/qlo/sequencestatistics.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** sequencestatistics.cpp 10 Aug 2006 16:09:53 -0000 1.1
--- sequencestatistics.cpp 2 Jan 2007 12:06:45 -0000 1.2
***************
*** 30,38 ****
new QuantLib::SequenceStatistics(dimension));
! QL_REQUIRE(weights.size()==0 || values.rows()==weights.size(),
"Values and weights vectors must have the same number of elements.");
! if (values.rows()!=0) {
! if (weights.size()!=0) {
for (QuantLib::Size i=0; i<values.rows(); i++) {
libraryObject_->add(values.row_begin(i),
--- 30,38 ----
new QuantLib::SequenceStatistics(dimension));
! QL_REQUIRE(weights.empty() || values.rows()==weights.size(),
"Values and weights vectors must have the same number of elements.");
! if (values.rows()>0) {
! if (!weights.empty()) {
for (QuantLib::Size i=0; i<values.rows(); i++) {
libraryObject_->add(values.row_begin(i),
Index: statistics.cpp
===================================================================
RCS file: /cvsroot/quantlibaddin/QuantLibAddin/qlo/statistics.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** statistics.cpp 28 Aug 2006 16:00:14 -0000 1.1
--- statistics.cpp 2 Jan 2007 12:06:45 -0000 1.2
***************
*** 29,37 ****
new QuantLib::Statistics());
! QL_REQUIRE(weights.size()==0 || values.size()==weights.size(),
"Values and weights vectors must have the same number of elements.");
! if (values.size()!=0) {
! if (weights.size()!=0)
libraryObject_->addSequence(values.begin(),
values.end(),
--- 29,37 ----
new QuantLib::Statistics());
! QL_REQUIRE(weights.empty() || values.size()==weights.size(),
"Values and weights vectors must have the same number of elements.");
! if (!values.empty()) {
! if (!weights.empty())
libraryObject_->addSequence(values.begin(),
values.end(),
|