|
From: Ferdinando A. <na...@am...> - 2007-07-12 11:01:40
|
Hi Fran=E7ois, On 7/11/07, fd...@us... <fd...@us...> wrote: > Revision: 11869 > http://quantlib.svn.sourceforge.net/quantlib/?rev=3D11869&view= =3Drev > Author: fdv1 > Date: 2007-07-11 09:28:06 -0700 (Wed, 11 Jul 2007) > > Log Message: > ----------- > CashFlows::npv signature changed to avoid useless dynamic memory allocati= on. > As a general rule I think that it might be a good practice to dereference= pointers or Handles as early as possible so we can use plain reference lat= er on. This would save indirections and remove the need to store objects sy= stematically in the heap. well, actually when it comes to general rules I'm more sensitive to the one that defines as mandatory to update your working copy and run successfully the test suite before committing to the trunk :-) Your change broke 3 test suites (asset swap, bonds, and convertible bonds): please revert it or fix it. thank you ciao -- Nando |