|
From: Ferdinando A. <na...@am...> - 2007-04-24 08:05:45
|
On 4/23/07, Luigi Ballabio <lui...@gm...> wrote: > Is there any reason why on the one hand the header > marketmodelconstrainedevolver.hpp became constrainedevolver.hpp while on > the other hand exercisevalue.hpp became marketmodelexercisevalue.hpp? The classes were named ConstrainedEvolver and MarketModelExerciseValue respectively, so I just renamed the files from the classes, to fix the confusion. I agree that MarketModelExerciseValue could be renamed just ExerciseValue... > Were we to choose, I'd go for the short format since the files are > contained in the marketmodel directory anyway. I wouldn't worry that the > class name doesn't match exactly the file name---and after all, it does > match if we take the parent folder into account. I prefer whenever possible the file name to match the class name. Any alternative can easily have some ambiguity, e.g. for classes as ParametricExercise (in the montecarlo folder) and MarketModelParametricExercise (in the marketmodel folder) ciao -- Nando |