|
From: Ferdinando A. <na...@am...> - 2004-04-21 16:57:08
|
Xavier thank you for the contribution. In addition to Luigi's questions: >1) is the copyright owned by you or FIMAT? >2) in either case, can you get from FIMAT a statement that it's ok for >them if you contribute code under the QuantLib license? >3) is there any particular reason you don't name the official source >for the calendar info? Otherwise, it'd be nice to put it in the docs. a) not all holidays have been documented in the hpp file. This can be easily fixed. b) Lunar New Year, Tomb Sweeping, Dragon Boat, Mid-Autumn Festival, Buddha's birthday, Harvest Moon, Tuen NG Festival, Chung Yeung fest, ecc are provided for 2004, 2005, 2006. Is there an algorithm for calculating them? If the algo is not easy shouldn't we tabulate them as we do for Easter Monday? c) Honk Kong calendar: you list "Day after Good Friday", but since this is a Saturday it shouldn't be listed as a separate holiday. Am I wrong? ciao -- Nando |