From: Luigi B. <lui...@fa...> - 2003-07-23 11:38:29
|
Hi Andre, At 09:24 AM 7/23/03 +0200, Andre Louw wrote: > > b) As a matter of personal taste entirely, and therefore fully discardable >on your part, > > I'm not enthusiastic about Date::Date(string). I'd rather keep the class >clear from IO (Ditto for Period.) > >I did this solely to make my life in SWIG easier, but I'll put my back into >it and clean up. We can leave the additional constructor in SWIG---it just takes to write %extend Date { Date(const std::string& s, const std::string& fmt) { return new Date(DateParser::parse(s,fmt)); } } > > c) Maybe Period::operator== should be a partial function. > >Not quite sure I understand what you mean? I slipped into math talk--or maybe some other field? I meant "not defined upon the whole domain", since there are pairs of Periods for which it is ambiguous. Bye, Luigi |