|
From: Peter C. <pca...@gm...> - 2015-08-27 07:16:19
|
... another idea would be to remove the core from IncrementalStatistics and replace it with boost accumulators (they are present since 1.36, so it should be ok), just leaving the interface in place. Shall I do that ? Peter On 20 August 2015 at 17:56, Peter Caspers <pca...@gm...> wrote: > Hi, > > here > > https://github.com/lballabio/quantlib/blob/master/QuantLib/ql/math/statistics/incrementalstatistics.cpp#L56 > > is a check for a negative variance estimation. Indeed I observe this > happens due to numerical issues sometimes. However, if this is the > only source for the exception to be thrown, couldn't we just omit the > check and return the value or if you want max ( v, 0.0 ) ? > > In applications it is somewhat unexpected to get an exception when > just asking for a variance estimation on valid data. > > Thank you > Peter |