Re: [Quantlib-dev] Dangerous constructor in Handle class

[Ferdinando A. <na...@am...>]

On Wed, Jul 20, 2011 at 11:05 AM, Luigi Ballabio
<lui...@gm...> wrote:
> On Tue, 2011-07-19 at 18:03 -0400, Irakli Machabeli wrote:
>> What is the purpose of this constructor for the handle class?
>>
>> template <class T>
>> inline Handle<T>::Handle(T* p,bool registerAsObserver)
>> : link_(new Link(boost::shared_ptr<T>(p),registerAsObserver)) {}
>
> I guess it's just a shortcut to avoid declaring the boost shared pointer
> explicitly.  It's not much more dangerous than the shared_ptr
> constructor (you can have the same problem) but I agree that at least it
> should be documented.  I wouldn't remove it, because we're keeping
> backward compatibility with previous releases; but we can mark it as
> deprecated.

done

ciao -- Nando