[Quantlib-dev] [ quantlib-Patches-3064571 ] unitofmeasureconversionmanager.hpp change

[SourceForge.net <no...@so...>]

Patches item #3064571, was opened at 2010-09-12 03:38
Message generated for change (Comment added) made by lballabio
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312740&aid=3064571&group_id=12740

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: manas (manasb)
>Assigned to: Luigi Ballabio (lballabio)
Summary: unitofmeasureconversionmanager.hpp change

Initial Comment:
removed friend reference to the class from which it is derived ie 

class UnitOfMeasureConversionManager
        : public Singleton<UnitOfMeasureConversionManager> {
        friend class Singleton<UnitOfMeasureConversionManager>;

to

class UnitOfMeasureConversionManager
        : public Singleton<UnitOfMeasureConversionManager> {
    


----------------------------------------------------------------------

>Comment By: Luigi Ballabio (lballabio)
Date: 2010-09-13 11:29

Message:
No, the friend declaration is correct.  The error was having the
UnitOfMeasureConversionManager constructor public; it should be private (to
prevent client code to instantiate it; only the Singleton machinery should)
at which point the base Singleton class must be a friend.  Thanks for the
heads-up anyway; the issue will be fixed in next release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312740&aid=3064571&group_id=12740