Re: [Quantlib-dev] unreferenced formal parameters in Commodity unitofmeasureconversion code

[Luigi B. <lui...@gm...>]

On Thu, 2009-12-03 at 15:54 +0100, Luigi Ballabio wrote:
> On Thu, 2009-12-03 at 15:47 +0100, Ferdinando Ametrano wrote:
> > I've fixed what I think is a bug in UnitOfMeasureConversion and
> > consequently enabled some commented out code in
> > UnitOfMeasureConversionManager:
> > http://quantlib.svn.sourceforge.net/viewvc/quantlib?view=rev&revision=16858
> > 
> > anyone using (or interested into) the commodity code please take a look at it
> 
> Done. For the readability of the logic, I much preferred directLookup
> and smartLookup to lookupImpl(true) and lookupImpl(false).

...and from what I see, the smart lookup is still broken.
I'll give it a look later.

Luigi


-- 

Steinbach's Guideline for Systems Programming: 
Never test for an error condition you don't know how to handle.