|
From: Luigi B. <lui...@gm...> - 2009-11-16 15:39:59
|
On Wed, 2009-10-21 at 11:50 +0200, Ferdinando Ametrano wrote:
> I suggest you to just replace the current implementation with
>
> #include <boost/date_time/gregorian/gregorian.hpp>
> [...]
> bool Date::isLeap(Year y) {
> return boost::gregorian::gregorian_calendar::is_leap_year(y);
> }
> [...]
>
> I will commit this change unless objections are raised
Nando,
with this change, one need to link the binary Boost.Date library with
QuantLib (whereas before this, the library only needed the Boost
headers.)
I might be fine with this if we used Boost.Date to implement most of our
Date class, but I wouldn't introduce the dependency just for checking
leap years beyond 2200...
Luigi
--
I hate quotations.
-- Ralph Waldo Emerson
|