[Quantlib-dev] [ quantlib-Patches-2871739 ] Kernel Interpolation Update

[SourceForge.net <no...@so...>]

Patches item #2871739, was opened at 2009-10-02 10:27
Message generated for change (Comment added) made by lballabio
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312740&aid=2871739&group_id=12740

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Luigi Ballabio (lballabio)
Summary: Kernel Interpolation Update

Initial Comment:
Changed some functions to const and by reference parameter passing. The passed 
kernel is now a template type. Can be used as before, but now any object that has
an operator()(Real x) can be passed. In particular boost function objects.

----------------------------------------------------------------------

Comment By: Luigi Ballabio (lballabio)
Date: 2009-10-06 14:23

Message:
yVec_(xSize_) in the constructor is fine as long as xSize_ is listed before
yVec_ in the class declaration.

As the Kernel is a template argument, we no longer need polymorphism, so
we can pass by copy. This also avoids having to wrap function pointers or
boost::functions into shared_ptrs.

----------------------------------------------------------------------

Comment By: Dimathematician (dimathematician)
Date: 2009-10-06 13:06

Message:
Ok, thanks. So far, I've avoided to use something like yVec_(xSize_) in the
constructor,
when xSize_ has been set in the same constructor earlier. Had some nasty
buggs with
such a setup, since xSize_ wasn't set at this stage or was set to some
random value. In
this cases, yVec_ wasn't allocated correctly. And you don't want to add
the kernel as
a shared_ptr?

----------------------------------------------------------------------

Comment By: Luigi Ballabio (lballabio)
Date: 2009-10-05 18:04

Message:
The patch was applied (with some modifications) to the code repository.
It will be included in next release.
Thank you.


----------------------------------------------------------------------

Comment By: Luigi Ballabio (lballabio)
Date: 2009-10-05 10:21

Message:
Would it be possible to have a context diff? It would make it easier to
apply it correctly.
On the command line, add -C 3 to the diff invocation.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312740&aid=2871739&group_id=12740