[Quantlib-dev] [ quantlib-Bugs-2534054 ] Line 409: svd.cpp

[SourceForge.net <no...@so...>]

Bugs item #2534054, was opened at 2009-01-25 00:57
Message generated for change (Comment added) made by lballabio
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112740&aid=2534054&group_id=12740

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Luigi Ballabio (lballabio)
Summary: Line 409: svd.cpp

Initial Comment:
The comparison (I think) is against p-1, not p.

ks starts at p-1 and goes backwards so it can NEVER be equal to p anyway.

- Damian

----------------------------------------------------------------------

>Comment By: Luigi Ballabio (lballabio)
Date: 2009-02-17 10:57

Message:
It looks like an excess of caution.  The comparison against p is, I think,
so that we don't access the e array out of bounds. As you say, it's not
going to happen since ks starts at p-1. But it doesn't hurt either.

----------------------------------------------------------------------

Comment By: Luigi Ballabio (lballabio)
Date: 2009-01-26 10:40

Message:
Do you mean line 309?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112740&aid=2534054&group_id=12740