|
From: Joseph W. <jo...@gn...> - 2008-07-16 03:35:06
|
I think you are right here. I put this in because I needed to have the
buildbot slave point to the directory of the just compiled quantlib, but I
can encode that in the command line rather than the makefile.
On Tuesday 15 July 2008 04:36:02 am Luigi Ballabio wrote:
> On Sat, 2008-07-12 at 12:56 -0700, dr...@us... wrote:
> > Log Message:
> > -----------
> > pull in quantlib-config from install directory even if it is not part
> > of the path
> >
> > all-local: .build-stamp
> >
> > .build-stamp: QuantLib/quantlib_wrap.cpp QuantLib/QuantLib.py
> > - CXXFLAGS="$(CXXFLAGS)" $(PYTHON) setup.py build
> > + PATH="${bindir}:${PATH}" CXXFLAGS="$(CXXFLAGS)" $(PYTHON) setup.py
> > build touch .build-stamp
>
> Joe,
> I'm not sure about this---you're changing the PATH without telling the
> user. At the very least, I'd put ${bindir} _after_ the original path.
> But I think that if the user installed quantlib-config in some
> non-standard place, it should be up to him to add it to the path when
> running configure.
>
> Luigi
|