Re: [Quantlib-dev] Visual Studio warning C4819

[Eric E. <eri...@na...>]

Hi All,

On Tue, March 4, 2008 4:10 pm, Ferdinando Ametrano wrote:
> On Tue, Mar 4, 2008 at 1:57 PM, Eric Ehlers <eri...@na...>
> wrote:
>>  >> At present, non-ASCII characters (>128, aka extended ASCII)
>>  >> appear in various comments and literal strings in the source code
>>  >>
>>  >> Some possible courses of action:
>>  >> 1) Restrict ourselves to the ASCII character set
>>  >> 2) Convert all source code files to Unicode format
>>  >> 3) Disable C4819
>>  >> 4) Do nothing and as today leave affected parties to work around the
>>  >> problem by implementing one of the above as a local hack
>>  >
>>  > Hmm. (3) seems strangely appealing...
>>  >
>>  > Luigi
>>
>>  It turns out, (3) doesn't work, at least not with "pragma warning
>>  disable".  When you load a cpp file containing a non-ASCII character, the
>>  compiler hits the problem character before it sees the pragma directive,
>>  so C4819 still appears everywhere.
>>
>>  The only way to disable the warning is to add /wd4819 to the compiler
>>  settings - any objection if I make that change?
>
> what is so hard about 2 ?
>
> ciao -- Nando

I don't know that (2) is hard and it's probably the correct full long term
solution, provided that it doesn't cause problems elsewhere in our
development environment - e.g. platforms other than Visual Studio on
Windows, subversion - which I suspect it doesn't.

For now, (3) is an immediate fix which I would argue is preferable to the
current state of affairs, so I went ahead and implemented that, if this
causes anyone any problems please let me know.

Regards,
Eric