Re: [Quantlib-dev] [QuantLib-svn] SF.net SVN: quantlib: [14226] trunk/QuantLib

[Luigi B. <lui...@gm...>]

On Thu, 2008-01-31 at 10:28 +0100, Ferdinando Ametrano wrote:
> >  How about putting MakeSwaption together with Swaption, instead? (And the
> >  same for the other helpers, of course.)
> 
> oh boy! as it often happens, I was thinking in the exact opposite direction ;-)
> I was considering to move the MakeSchedule code out of schedule.*pp
> into its own files.

Nando,
	this won't buy you anything. On the one hand, makeschedule.hpp would
include schedule.hpp, so other files that include makeschedule.hpp would
bring in schedule.hpp anyway. On the other hand, makeschedule.hpp
wouldn't include anything more than what's already included in
schedule.hpp (because all arguments of the MakeSchedule methods are
arguments of the Schedule constructor) so you don't save any inclusion
by removing it from schedule.hpp.  QED.  The same applies to other
MakeFoo classes.


> By the way, the _whole_ library is currently being recompiled as I
> write just because I've added 2 inspectors to the Option class.

Sure. But you have to weight it---how often do you expect to change the
Option class, now that you've added the missing inspectors? Ok, you'll
have to recompile the _whole_ library every four months. On the other
hand, we get a more logical structure. Seems acceptable to me...

Later,
	Luigi


-- 

Glendower: I can call spirits from the vasty deep. 
Hotspur: Why, so can I, or so can any man; 
But will they come when you do call for them? 
-- King Henry the Fourth Part I, Act III, Scene I