[qooxdoo-bugs] [Bug 5486] Dependency analisys should be able to handle filtered inlcudes
Brought to you by:
ecker,
martinwittemann
From: <bug...@qo...> - 2011-08-08 16:43:35
|
http://bugzilla.qooxdoo.org/show_bug.cgi?id=5486 --- Comment #1 from Thomas Herchenroeder <th...@us...> --- Added support for qx.core.Environment.filter(): - the variants it mentions are being picked up - it is optimized for the build version - it is honored if used in the 'include' class key, when calculating transitive load dependencies In the course of this we've decided to always create the source version without variants. This ensures all static class dependencies will be loaded, even if they are not needed at run time; but this assures that load-time dependencies like mixin references in calls to qx.core.Environment.filter() will be fullfilled. (This was an undetected issue in the old implementation with qx.core.Variant.select(), which could be used as the value for an 'include' class key, which would remove unneeded mixin dependencies from the class list, but the mixin references were still in the call to qx.core.Variant.select, which would cause a run time error). This will make the class list for the source version larger as for the build version, but this seems acceptable for it. But as soon as load dependencies are subject to variants, the source version as to cater for all of them. So rather than trying to find out which unneeded variants the source version needs to support nevertheless, we just support all of them. The build version remains unchanged, as it not only cuts off surplus dependencies from the class list, but also removes the references to them in the remaining class code With r28436. -- Configure bugmail: http://bugzilla.qooxdoo.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. |