#301 song title remains in window title when playlist is finished

[Anonymous]

Originally created by: nazark...@gmail.com

What steps will reproduce the problem?
1. Add some music to the playlist and play it until it's finished.

What is the expected output? What do you see instead?
The qmmp window title still shows the title of the last played song instead
of showing just 'Qmmp' (as is does when the playlist is empty).

What version of the product are you using? On what operating system?
0.5.0-svn-[r1706], archlinux

Please provide any additional information below.
The window title (especially shown in the taskbar) is a rather quick way to
understand that the playlist is over. So, if the song title still remains
there, it becomes a bit confusing.

[Anonymous]

Originally posted by: nazark...@gmail.com

And, I think, window title should be changed to 'Qmmp' when user stops playback
manually or clears the playlist. It's a standard behavior in a rather big bunch of
players I used.

[Anonymous]

Originally posted by: trialuser02

(No comment was entered for this change.)

Labels: Usability
Status: Accepted

[Anonymous]

Originally posted by: pano...@gmx.net

I created a small patch that does this, by removing some lines:

if (m_playlist->currentItem())
            setWindowTitle(m_playlist->currentItem()->text());

If I understand this correctly, this line will set the window title to the currently highlighted item in the playlist, after qmmp is stopped. Since this interferes with this issue, I had to remove this if/else statement :-)

(again, as with my previous patches: I am no programmer)