Re: [Qmidiarp-devel] New LFO Phase Feature and Global Store fixes

[Frank K. <goe...@ya...>]

Hi Mathew,

On 06/02/2020 04:17, Matthew McGuire wrote:
> Hi all,
>
> I have been using qmidiarp in my music studio for two to three years 
> now and over the course of last fall and this winter fixed a number of 
> bugs with the Global store and added a Phase offset feature to the LFO 
> module. I have all of this working for the Ubuntu Studio package which 
> is at version 0.6.5 according to the source. That's a bit behind the 
> one in GIT so I would need to fold my changes into that before you 
> could adopt them. I'm willing to do that if you are interested in the 
> changes. I'll save you the gory details of the changes in code, but 
> here is a quick list.

Thanks for proposing your fixes and additions here. They are certainly 
interesting and welcome, but it's the "gory details" that will be the 
most important part for now ;).

> Implemented LFO Phase slider that changes the starting point of the 
> LFO wave form.
>
> Fixed the Global Store LFO Restore pattern to work with MIDI CCs
>
> Fixed the Global Store Sequencer Restore pattern to work with MIDI CCs
>
> Created ENUMs for the various MIDI Ctrl IDs in the code to make them 
> easier to maintain. This is what fixed the two Global Store bugs 
> above. This is a breaking change to existing MIDI Control Settings.
>
The easiest would be if you cloned one of the qmidiarp git repositories 
(sourceforge or github) into an own git repository you'd setup, then 
apply the changes you list one by one as commits to it and then propose 
a pull request to either qmidiarp git repo. Alternatively you could send 
patches or a source tarball and let me diff out the changes you made and 
I can review and commit them for you. With a little chance this won't 
conflict so much with the changes since release 0.6.5.


> I did not touch the LV2 plugins or write a conversion function for the 
> Ctrl IDs that had to change.

The phase shift control should then also be available as an LV2 controller.

> I have used this build for a few weeks without any issues. Please let 
> me know if you are interested in any of it.
>
> Thanks,
>
> Matthew McGuire
>
Let me know what you want to do

Best

Frank


>
> _______________________________________________
> Qmidiarp-devel mailing list
> Qmi...@li...
> https://lists.sourceforge.net/lists/listinfo/qmidiarp-devel