qmailadmin-devel

[qmailadmin-devel] [PATCH] Mail robots don't always display properly

[John P. <jpe...@ro...>]

At least with MySQL, sometimes a mail robot will not display the 
forwarded address in qmailadmin (it will show the vacation line 
instead).  It seems that qmailadmin expects that the records will be 
returned in original insertion order and MySQL isn't always consistent 
about that.

I finally got sick of this and patched valias_select() in vpopmail itself:

==================================================================
--- vmysql.c  (revision 9)
+++ vmysql.c  (local)
@@ -1209,7 +1209,8 @@
      }

      qnprintf( SqlBufRead, SQL_BUF_SIZE, "select valias_line from valias \
-where alias = '%s' and domain = '%s'", alias, domain );
+where alias = '%s' and domain = '%s' \
+order by valias_line desc", alias, domain );

      if (mysql_query(&mysql_read,SqlBufRead)) {
          vcreate_valias_table();


HTH

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748

Re: [qmailadmin-devel] [PATCH] Mail robots don't always display properly

[Rick W. <vc...@de...>]

John Peacock wrote:

> At least with MySQL, sometimes a mail robot will not display the 
> forwarded address in qmailadmin (it will show the vacation line 
> instead).  It seems that qmailadmin expects that the records will be 
> returned in original insertion order and MySQL isn't always consistent 
> about that.
> 
> I finally got sick of this and patched valias_select() in vpopmail itself:

While that might fix your current problem, I believe the long term 
solution will require valias code to maintain any arbitrary ordering of 
entries.  I expect that to require adding an order field and sort on 
that.  I have plans for it, but not a lot of time.  It is pretty high on 
my list, but I wouldn't mind if someone beat me to it.  :)

Re: [qmailadmin-devel] [PATCH] Mail robots don't always display properly

[Tom C. <to...@to...>]

On Jan 4, 2005, at 4:35 PM, Rick Widmer wrote:
> While that might fix your current problem, I believe the long term 
> solution will require valias code to maintain any arbitrary ordering 
> of entries.  I expect that to require adding an order field and sort 
> on that.  I have plans for it, but not a lot of time.  It is pretty 
> high on my list, but I wouldn't mind if someone beat me to it.  :)

I agree wholeheartedly.

I think that the valias table needs an auto-incrementing serial number 
field, and reads from it should sort on that field.  That way, you get 
the entries out in the order they were written.

I could even be possible to re-order the entries for a particular alias 
if necessary, but I think that the auto-increment is a good solution.

Adding it will require changes to each SQL backend, along with a script 
for users to add the field to their existing databases and assign 
values to all existing entries.  Yuk.  I still have to get my updated 
vdelivermail code released...

--
Tom Collins  -  to...@to...
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/