qmailadmin-devel

[qmailadmin-devel] Why use "fprintf(stdout," instead of "printf("

[Tom C. <to...@to...>]

Does anyone know why the QmailAdmin source uses fprintf instead of 
printf to output its page?

I'm planning to clean up the output to escape HTML entities and CGI 
strings to take care of a few bugs.  For example:

Quotes in names will break the INPUT fields.
Email addresses that contain "+" won't work (links to modify/delete end 
up with spaces in them).
It's possible to embed HTML in some fields -- we need to convert '<' 
and '>' to '&lt;' and '&gt;'.

This may also be a start on supporting punycode domain names...

Anyway, I'm wondering whether I can just replace all of those fprintf 
calls with my modified printf (which will do the escaping).  As best I 
can tell, printf (x, y) is no different then fprintf (stdout, x, y).

The only benefit I could see to using fprintf everywhere, is that it 
would be possible to dump output to a file, but I think that would be 
of limited use with an interactive CGI script.

--
Tom Collins  -  to...@to...
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/

Re: [qmailadmin-devel] Why use "fprintf(stdout," instead of "printf("

[Rick W. <vc...@de...>]

Tom Collins wrote:

> Does anyone know why the QmailAdmin source uses fprintf instead of 
> printf to output its page?

Not I.


> Anyway, I'm wondering whether I can just replace all of those fprintf 
> calls with my modified printf (which will do the escaping). As best I 
> can tell, printf (x, y) is no different then fprintf (stdout, x, y).

There shouldn't be any problem that I can think of.


> The only benefit I could see to using fprintf everywhere, is that it 
> would be possible to dump output to a file, but I think that would be of 
> limited use with an interactive CGI script.

I have done that for debugging, but nothing that couldn't be done by 
adding a fprintf() when needed.

Remember, if you send something to stderr it ends up in the Apache error 
log.  Hopefully other web servers do something similar.  It is very 
handy to tail -f the error log file when debugging.  Logging error 
conditions to stderr is probably a good thing even when you aren't 
debugging.

Rick

p.s.  Are you sure you don't want to spend time on the PHP replacement 
ken is starting on?   From the simscan list:

 >>>Quick question,  possible to tie this process into qmailadmin ? i.e. in
 >>>> >>future, build qmailadmin with --enable-simscan or something 
similar ?
 >>
 >>> >
 >>> > We are looking at hooking it into a new php interface that will
 >>> > replace qmailadmin and vqadmin.
 >
 >>
 >> PHP?  <gasp>  COOL!!!
 >>
 >> If I can help, let me know...


Will do :)
Ken