#156 some coding problems.

PyXB 1.1.5
closed
None
fixed
Code
minor
PyXB 1.1.4
defect
2012-09-14
2012-06-29
hhsprings
No

for personal purpose, i tried passing pyxb-1.1.4 to Cython,
then, Cython rejects some your codes.

plase see atached for details.

  i know keeping up pyxb as pure python is signigicant especially for Jython, etc,
  so i would not request to make pyxb to c-ish ;-)
  i'm just evaluating Cython itself now rathar than pyxb.
  (incidentally, simply compiling ``binding`` modules (except datatypes_facets) with cython,
  my experimental script took 33% speedup .)
1 Attachments

Discussion

  • hhsprings

    hhsprings - 2012-06-29
     
  • hhsprings

    hhsprings - 2012-06-29
    • milestone changed from PyXB 1.1.4 to PyXB 1.1.5
     
  • hhsprings

    hhsprings - 2012-06-29

    x pluse see
    o please see

    x signigicant
    o significant

    :-<

     
  • Peter A. Bigot

    Peter A. Bigot - 2012-08-25
    • status changed from new to accepted

    Thanks; this is quite helpful. All fixes suggested by cython have been pushed to the next branch. I'll run it by pyflakes later.

     
  • Peter A. Bigot

    Peter A. Bigot - 2012-08-25

    I should say that cython's complaints that float, long, and int are redefined in the datatypes module is something I don't think can be fixed. Those redefinitions are intentional.

     
  • Peter A. Bigot

    Peter A. Bigot - 2012-08-25
    • status changed from accepted to closed
    • resolution set to fixed

    As of commit below, all pyflakes warnings have been addressed except:
    module imports that are unused within the module, but are used by second parties
    a nasty mutual dependency that has datatypes_facets importing * from datatypes
    anything in any generated file (like pyxb.bundles.)

    commit 8da476614985342cddf0faf17d9a7e0ad499ee3c
    Author: Peter A. Bigot <pab@‌>
    Date: Sat Aug 25 12:50:01 2012 -0500

    pyflakes cleanup: pyxb/binding

     
  • hhsprings

    hhsprings - 2012-09-14
    • status changed from closed to reopened
    • resolution fixed deleted

    binding/generate.py (line2319):

                assert bindable_fn(c), 'Unexpected %s in binding components' % (type(s),)
    

    typo?

                assert bindable_fn(c), 'Unexpected %s in binding components' % (type(c),)
    
     
  • Peter A. Bigot

    Peter A. Bigot - 2012-09-14
    • status changed from reopened to closed
    • resolution set to fixed

    Yes, but re-opening this ticket is not appropriate as this is a new issue in subsequently added code. I won't always run all the warning checks before pushing something onto next. I've opened #167 for this.

     
  • hhsprings

    hhsprings - 2012-09-14

    re-opening this ticket is not appropriate as this is a new issue in subsequently added code.

    i see.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks