[pywin32-bugs] [ pywin32-Bugs-1590399 ] Refcounting in ui_assoc_object::GetGoodRet

[SourceForge.net <no...@so...>]

Bugs item #1590399, was opened at 2006-11-04 11:12
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1590399&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pythonwin
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: kxroberto (kxroberto)
Assigned to: Nobody/Anonymous (nobody)
Summary: Refcounting in ui_assoc_object::GetGoodRet

Initial Comment:
I wonder if the below patch possibly addresses a
refcount/memory problem. Think its possible, that
DODECREF(this) frees <*this> from memory, another
released threads malloc uses the memory and
this->virtualInst is bogus?

( In preceding function  ui_assoc_object::DoKillAssoc
there is a simlar technique to do "PyObject *vi =
virtualInst;" - but for reverse reason )

( I'm still in search of memory leaks/crashes on dual
cores and fast CPUs when other threads are going on
parallel to win32ui GUI mainthread. )



--- win32assoc.cpp.orig	2005-04-12 17:01:00.000000000 +0200
+++ win32assoc.cpp	2006-11-04 10:59:46.326646400 +0100
@@ -252,9 +252,10 @@
 {
 	if (this==NULL) return NULL;
 	if (virtualInst) {
+		PyObject *vi = virtualInst;
+		DOINCREF(vi);
 		DODECREF(this);
-		DOINCREF(virtualInst);
-		return virtualInst;
+		return vi;
 	} else
 		return this;
 }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1590399&group_id=78018