[pywin32-bugs] [ pywin32-Bugs-1512715 ] CVirtualHelper::call / do_call double DODECREF Bug ?

[SourceForge.net <no...@so...>]

Bugs item #1512715, was opened at 2006-06-26 23:24
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1512715&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pythonwin
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: kxroberto (kxroberto)
Assigned to: Nobody/Anonymous (nobody)
Summary: CVirtualHelper::call / do_call double DODECREF Bug ?

Initial Comment:
(last seen in 207/208)
For example 

BOOL CVirtualHelper::call(const MSG *msg)

does

	BOOL ret = do_call(arglst);
	DODECREF(arglst); // my reference.

but BOOL CVirtualHelper::do_call(PyObject *args) also does

	PyObject *result = gui_call_object(handler,args);
	DODECREF(args);


Seems this explains a couple of OS-level crashes and
sudden disappearance of objects here (mainly on dual
cores), where the virtual PyCWnd.PreTranslateMessage is
used.

But attention! Most of the CVirtualHelper::call's on
the other side rely on the DODECREF(args) in do_call -
e.g.:

the "wrong" ones doing an extra DODECREF seem to be only

BOOL CVirtualHelper::call(const MSG *msg)

and 

BOOL CVirtualHelper::call(UINT nID, int nCode, void*
pExtra, AFX_CMDHANDLERINFO*pHandlerInfo)




----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2006-07-11 15:20

Message:
Logged In: YES 
user_id=14198

Yeah - I can see how that is happening - thanks!  I've
checked it in as part of bug 1489690


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1512715&group_id=78018