[pywin32-bugs] [ pywin32-Bugs-3611214 ] Bad error checking in win32Print.DocumentProperties

[SourceForge.net <no...@so...>]

Bugs item #3611214, was opened at 2013-04-17 09:16
Message generated for change (Comment added) made by rupole
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3611214&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dennis (rdsteed)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bad error checking in win32Print.DocumentProperties

Initial Comment:
I'm trying to troubleshoot some problems I have using win3wPrint.DocumentProperties.  I get strange results returned in DevModeOutput but no errors are raised.

Possible solution:

I think the problem is in win32Print.cpp.

Lines  of win32Print.cpp (current version after changeset 4299)

  1346 		rc=DocumentProperties(hwnd, hprinter, devicename, dmoutput, dminput, mode);
  1347 		if (ret < 0)
  1348 			PyWin_SetAPIError("DocumentProperties");

In line 1347, ret is not yet defined.  The code should actually be testing for rc<0 :

  1346 		rc=DocumentProperties(hwnd, hprinter, devicename, dmoutput, dminput, mode);
  1347 		if (rc < 0)
  1348 			PyWin_SetAPIError("DocumentProperties");






----------------------------------------------------------------------

>Comment By: Roger Upole (rupole)
Date: 2013-04-19 00:26

Message:
Fix has been applied

----------------------------------------------------------------------

Comment By: Roger Upole (rupole)
Date: 2013-04-17 11:31

Message:
Thanks for spotting that.  I'll get the fix in place before the next
release.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3611214&group_id=78018