[pywin32-bugs] [ pywin32-Bugs-3611214 ] Bad error checking in win32Print.DocumentProperties
OLD project page for the Python extensions for Windows
Brought to you by:
mhammond
From: SourceForge.net <no...@so...> - 2013-04-17 16:17:27
|
Bugs item #3611214, was opened at 2013-04-17 09:16 Message generated for change (Settings changed) made by rdsteed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3611214&group_id=78018 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dennis (rdsteed) Assigned to: Nobody/Anonymous (nobody) >Summary: Bad error checking in win32Print.DocumentProperties Initial Comment: I'm trying to troubleshoot some problems I have using win3wPrint.DocumentProperties. I get strange results returned in DevModeOutput but no errors are raised. Possible solution: I think the problem is in win32Print.cpp. Lines of win32Print.cpp (current version after changeset 4299) 1346 rc=DocumentProperties(hwnd, hprinter, devicename, dmoutput, dminput, mode); 1347 if (ret < 0) 1348 PyWin_SetAPIError("DocumentProperties"); In line 1347, ret is not yet defined. The code should actually be testing for rc<0 : 1346 rc=DocumentProperties(hwnd, hprinter, devicename, dmoutput, dminput, mode); 1347 if (rc < 0) 1348 PyWin_SetAPIError("DocumentProperties"); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3611214&group_id=78018 |