[pywin32-bugs] [ pywin32-Bugs-1051453 ] win32pdhutil.browse broken (intentionally?)

[SourceForge.net <no...@so...>]

Bugs item #1051453, was opened at 2004-10-21 22:53
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1051453&group_id=78018

Category: win32
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Greg Chapman (glchapman)
Assigned to: Nobody/Anonymous (nobody)
Summary: win32pdhutil.browse broken (intentionally?)

Initial Comment:
The win32pdhutil.browse function no longer displays a
dialog as documented in the "Python Programming on
Win32" book.  Looking at the CVS history, revision 1.6
removed the call to win32pdh.BrowseCounters and the
subsequent "def test():" declaration, so that the code
which was in the test function is now in browse.  I'm
wondering if this was an accident, since browse still
takes the same parameters, but it doesn't use them.  If
the change was intentional, I think some comment
explaining it is in order, especially since
BrowseCounters still seems to work just fine given the
parameters browse was giving it.


----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2005-03-05 16:06

Message:
Logged In: YES 
user_id=14198

Thanks - that was indeed a mistake!

Checking in win32pdhutil.py;
new revision: 1.9; previous revision: 1.8

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1051453&group_id=78018