[pywin32-bugs] [ pywin32-Bugs-1101347 ] Docking toolbar AV at shut down

[SourceForge.net <no...@so...>]

Bugs item #1101347, was opened at 2005-01-13 13:01
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1101347&group_id=78018

Category: pythonwin
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Greg Chapman (glchapman)
>Assigned to: Mark Hammond (mhammond)
Summary: Docking toolbar AV at shut down

Initial Comment:
In pythonwin build 203, the
CPythonWndFramework::_BaseOnClose method has a
try/except handler which masks an access violation
which occurs on shutdown.  I believe the reason for the
AV is this bug in MFC (specifically in DestroyDockBars):

http://support.microsoft.com/default.aspx?scid=kb;EN-US;884030

Explicitly destroying the bars in MainFrame.OnClose
(from intpyapp.py) seems to fix the problem: see the
attached diff.

By the way, I think something was going wrong with the
exception handling in _BaseOnClose.  When run under the
VS 7.1 debugger, Pythonwin would end up jumping to an
illegal address and faulting.  I believe that it has
not been shutting down correctly, and that's why it
always left an icon in the taskbar.  Along with the
change to initpyapp, I took out the exception handler
and rebuilt win32ui.pyd.  Pythonwin seems to shut down
correctly.


----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2005-03-05 10:38

Message:
Logged In: YES 
user_id=14198

Thanks - this looks great to me!  I don't suppose you have
any ideas on the docking toolbars? :)  I've failed a few
times now - I'll give it another quick go now.  My most
recent checkin to debugger.py should be reverted - it didn't
solve the problem (although the ToolbarDebugging entries no
longer leak, now only ToolbarDefault).  Not saving the state
at all is wrong though.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=1101347&group_id=78018