[pywin32-bugs] [ pywin32-Feature Requests-3433757 ] Full LOGFONT struct implementation

[SourceForge.net <no...@so...>]

Feature Requests item #3433757, was opened at 2011-11-04 20:29
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551957&aid=3433757&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pythonwin
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kris Hardy (krishardy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Full LOGFONT struct implementation

Initial Comment:
The current implementation of the LOGFONT struct in Pythonwin/win32util.cpp is not complete, relative to the WinGDI.h in the Windows 7.1 SDK.  Attached is a proposed patch to support the full LOGFONT struct.

Notes:
I reordered the szFont* static strings, the documentation, the dict building order in LogFontToDict(), and the LOGFONT packing order in DictToLogFont().  This was done purely for asthetics in order to have the orders match that of the LOGFONT struct.

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2011-11-04 21:00

Message:
Thanks for the patches - a couple of notes:

* CHANGES.txt should have these in the "Since 216" section - 217 is yet to
be released.  In that same file, please wrap the lines to 80 chars, remove
the URL to MSDN and if you like, add your name at the end of the paragraph
- something like "(feature request 3433757 by Kris Hardy)

* Please remove the notes similar to "2011-11-02 Extended by Kris Hardy
..." - I prefer keeping those notes out of the code and let hg tell us that
- if similar notes were added for every change it would get messy pretty
quickly :)  It is fine in the CHANGES file though, as mentioned above.

* Pythonwin/win32util.cpp is indented with tabs where you have used
spaces.  Tabs should be used for consistency (oh - I see now the second
patch does that)

* In that same file, the existing comment:
 	// ??? This is missing a lot of members ???
  is now out of date, right?  If so it should be removed.

If you can generate a single new patch with those changes I'll check it
in!

Thanks,

Mark

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551957&aid=3433757&group_id=78018