[pywin32-checkins] /hgrepo/p/py/pywin32/pywin32: remove duplicated menu code which ...

[<pyw...@li...>]

changeset 86f428f44fca in /hgrepo/p/py/pywin32/pywin32
details: http://pywin32.hg.sourceforge.net/hgweb/pywin32/pywin32/hgrepo/p/py/pywin32/pywin32?cmd=changeset;node=86f428f44fca
summary: remove duplicated menu code which pulls in extra deps with py2exe etc

diffstat:

 CHANGES.txt                    |  7 ++++++-
 Pythonwin/pywin/mfc/docview.py |  8 +-------
 2 files changed, 7 insertions(+), 8 deletions(-)

diffs (43 lines):

diff -r bda8b9f07486 -r 86f428f44fca CHANGES.txt
--- a/CHANGES.txt	Sat Oct 22 18:08:01 2011 +1100
+++ b/CHANGES.txt	Sat Nov 05 14:41:55 2011 +1100
@@ -6,6 +6,11 @@
 
 Since build 216:
 ----------------
+
+* Remove some duplicated menu code from pythonwin which should avoid
+  having py2exe pulling in most of the pythonwin framework in some cases
+  (patch 3433527 from kxroberto.)
+
 * A new win32com.client.VARIANT object can be used for advanced control over
   the parameter types passed to some COM methods.  See the documentation in
   win32com/HTML/variant.html (also included in the help file)
@@ -18,7 +23,7 @@
 * Pythonwin now warns, but allows you to continue, when saving a file with
   an invalid encoding line (bug 3139486)
 
-* Fix win32com.client.WithEvents on py3k (bug bug 3199843)
+* Fix win32com.client.WithEvents on py3k (bug 3199843)
 
 * When passing integers/unsigned integers to COM objects which did not fit 
   into 32bits, OverflowErrors were silently discarded and -1 was silently 
diff -r bda8b9f07486 -r 86f428f44fca Pythonwin/pywin/mfc/docview.py
--- a/Pythonwin/pywin/mfc/docview.py	Sat Oct 22 18:08:01 2011 +1100
+++ b/Pythonwin/pywin/mfc/docview.py	Sat Nov 05 14:41:55 2011 +1100
@@ -69,14 +69,8 @@
 		self.MakeFrame=MakeFrame
 		self.MakeView=MakeView
 		self._SetupSharedMenu_()
-# todo - _SetupSharedMenu should be moved to a framework class.
 	def _SetupSharedMenu_(self):
-		sharedMenu = self.GetSharedMenu()
-		from pywin.framework import toolmenu
-		toolmenu.SetToolsMenu(sharedMenu)
-		from pywin.framework import help
-		help.SetHelpMenuOtherHelp(sharedMenu)
-
+		pass # to be overridden by each "app"
 	def _CreateDocTemplate(self, resourceId):
 		return win32ui.CreateDocTemplate(resourceId)
 	def __del__(self):