[pywin32-bugs] [ pywin32-Patches-1727357 ] new VC8.0 build patch for AMD64 branch (inc axdebug)

[SourceForge.net <no...@so...>]

Patches item #1727357, was opened at 2007-05-29 20:13
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551956&aid=1727357&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Steve Yin (steveyin)
Assigned to: Nobody/Anonymous (nobody)
Summary: new VC8.0 build patch for AMD64 branch (inc axdebug)

Initial Comment:
hi mhammond, I have reviewed the patch you committed to cvs, there is still a little bug in cvs. In my previous patch, I totally ignored the axdebug extenstion, because I can not find activdbg.h header in vista sdk.

I found the activdbg.h header exists in the lastest platform sdk, which is build for Windows Server 2003 SP1. So, here comes completed patch for amd64 ;-)

PS. I have to remove the depend of dsound.h, because setup.py just can not find it. and, I also upload a patch for distutils. this patched version can handle the manifest file.

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2009-02-07 15:30

Message:
Thanks - I've checked in a slightly modified version of this.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2009-02-07 15:29

Message:
Thanks - I've checked in a slightly modified version of this.

----------------------------------------------------------------------

Comment By: Steve Yin (steveyin)
Date: 2007-05-30 11:52

Message:
Logged In: YES 
user_id=1613955
Originator: YES

OK, as I said before, in latest activdbg.h, IEnumDebugStackFrames is a
define to IEnumDebugStackFrames64 under x64 and defined to
IEnumDebugStackFrames32 under win32, so I made these change.

and, in latest activdbg.h dwSourceContext is DWORDLONG under x64, and
DWORD under win32. this is a pointer value, x64 use 8 bytes (dwordlong) as
a pointer, win32 use 4 bytes (dword) that is the difference.

in PyWinTypes.h, I have to remove these functions, because it will cause
the link fail, it says PyWinObject_AsWCHAR already as a body. and the
wchar_t is default on in vc8, default off before vc8(vc7.x, vc6).

I'm confused about win32net.h and win32netmodule.cpp, in Visual Studio
IDE, the last parameter  of PFNSIMPLEENUM and PFNNAMEDENUM need to be
PDWORD_PTR, but, if i'm using setup.py, it need to be changed back to
LPDWORD, you can see, LPDWORD is a pointer , PDWORD_PTR is a pointer too. I
really confused about these two types :-( . I'm not sure about the patch of
these two file, you can just delete these from the patch.

I also need to say, the patch to distutil is only needed under vc8, I
added /Zc:wchar_t- to disable default wchar_t, I don't know this has been
changed in python 2.6, and /D_CRT_SECURE_NO_WARNINGS to disable a looot of
stupid warning of vc8, and the manifest file merge.

I also uploaded the latest activdbg.h, this file has a modification date
of 2006-3-3, just a half year before these active script header in updated
vista sdk. you can see the IEnumDebugStackFrames is a define. ;-)
File Added: activdbg.rar

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2007-05-29 23:20

Message:
Logged In: YES 
user_id=14198
Originator: NO

Thanks for the update.  MSDN documents the dwSourceContext params as
DWORD_PTR (rather than DWORDLONG).  So we need to change both the
"interface" and "gateway" side of this to use
PyWinObject_As[/From]DWORD_PTR to handle this param (so it works as well as
compiles ;)  That should also make it possible to remove the #ifdef's.

The change involving IEnumDebugStackFrames64 will also be a problem -
nothing in pywin32 will implement that, so it will fail at runtime.

You included a patch to PyWinTypes.h and win32\* which reverse previous
changes I made.  Was this intentional?  If so, what was the problem you
faced?

If we can sort these out, I'd be happy to apply it!

Thanks - I'll check out the distutils patch tomorrow or the next day...

----------------------------------------------------------------------

Comment By: Steve Yin (steveyin)
Date: 2007-05-29 20:16

Message:
Logged In: YES 
user_id=1613955
Originator: YES

here comes the patch for distutils.

there are some of bugs in pythonwin, maybe it's amd64 related, but I don't
have time to debug it. Sorry.
File Added: distutils-vc8.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551956&aid=1727357&group_id=78018