Re: [pywin32-checkins] pywin32/adodbapi adodbapi.py, 1.2.2.1, 1.2.2.2

[Vern C. <kf...@ya...>]

Argh! I'm still struggling with version control -- learning three at once. My personal & commercial stuff is on Bazaar so I only use CVS for pywin32 and am not too good with it. I intended that this checkin be applied to the py3k fork only. It was supposed to update that branch with the same changes I already applied to the trunk as version 2.2.2. (Please tell me that one made it.)

I used python 2.6 for testing because I needed to import pythoncom and win32com, which work on 2.6 and I assumed were not yet ready on py3k. (If I had compiled them would they have worked?)

This code merges your changes and mine from the trunk, and Roger Upole's from the py3k fork, and a bit of new work for compatibility. I updated the version number to 2.2.3 to reflect the changes that let it work with either 2.6 or 3.0. (It has to use "buffer" in 2.6 and "memoryview" in 3.0) I dropped the 2.3 specific code as superfluous in that fork. 

So these changes are known to work on 2.6 and may (hopefully) work in py3k and some future IronPython 3.0.  Would you be so kind as to make sure that this update is in the py3k fork where it belongs? I don't want to make things worse by fumbling with it.
--
Vernon

--- On Wed, 11/12/08, Mark Hammond <mha...@sk...> wrote:

> From: Mark Hammond <mha...@sk...>
> Subject: RE: [pywin32-checkins] pywin32/adodbapi adodbapi.py,1.2.2.1,1.2.2.2
> To: "'Vernon Cole'" <kf...@us...>, pyw...@li...
> Date: Wednesday, November 12, 2008, 9:46 PM
> > +     version 2.2.3 update for Python 3, require python
> 2.6 or later
> 
> Ack - the rest of pywin32 will support 2.3 and up, and will
> stick with a 2.x
> syntax, in the interests of avoid a "fork" into 2
> incompatible code-bases.
> I'm slowly going through the py3k branch and reverting
> all the 3k specific
> things - is there any chance we can revert all non 2.4
> compatible changes
> and apply them only to the trunk?
> 
> Thanks,
> 
> Mark