From: Kevin A. <al...@se...> - 2005-07-27 00:32:57
|
On Jul 26, 2005, at 3:45 PM, Alex Tweedly wrote: > Kevin Altis wrote: > >> On Jul 26, 2005, at 2:59 PM, Alex Tweedly wrote: >> >>> Kevin Altis wrote: >>> >>>> >>>> So, again my suggestion is that your resourceEditor be added to >>>> tools as its own directory and files. >>>> >>> Cool, I'll do that. >>> (btw - it's only 4 files that have changed plus two new ones added - >>> but they amount to 3400 out of a total of just over 4000 lines, so I >>> don't think there's noticeable saving from keeping the unchanged >>> files in common). >>> >>> I'll see if there's any feedback on the self-adjusting layout, and >>> expect to do the commit this week (pending any other opinions in >>> response to this) >>> >> >> Hmm, if it is only four files, then it might be better to just do >> some module name changes if that is possible. This would be similar >> to how codeEditorR was done, which would give you the option of >> subclassing if that makes sense. What are the four files and what >> dependencies do they have that would cause problems? >> > It changes > resourceEditor.py > modules/resourceOutput.py > modules/propertyEditor.py > modules/propertyEditor.rsrc.py > and adds > modules/multiComponents.py > modules/multiComponents.rsrc.py > > The two that matter - resourceEditor.py and propertyEditor.py are both > fairly extensively changed. I can't see how it could be done by > subclassing - but I'll go look at the codeEditoR some more in case I'm > over-estimating the problems. > Subclassing was just one option, but given how extensive the changes are that you've described, probably a bad one and not necessary for your initial checkin. Instead, what I expect would be better is to rename your copy of resourceEditor.py, rename resourceOutput.py, and the propertyEditor.py and propertyEditor.rsrc.py files. Then change the imports in your files to use the newly renamed files as well as update the places those modules are referenced in the code. Since PythonCard code files avoid import * like the plague I don't think there will be any spots of ambiguity. I used findfiles to search for references to the resourceOutput module in the resourceEditor directory, I only see five lines, all in resourceEditor.py, so that is easily updated in your new files without any chance of conflicts. In the case of the propertyEditor module there are only two lines impacted in resourceEditor.py, and if you keep the same style import, then you only have to change the import line to use the newly renamed propertyEditor.py module. Since it doesn't appear there are any circular import references in resourceOutput.py or propertyEditor.py, that should solve the problem with a minimal of fuss. Obviously, you'll need to update your propertyEditor.py module to use the newly renamed resourceOutput.py module too. I suggest using the same prefix for the new resourceEditor.py as well as your updated modules so that it is clear that they go together. Let me know if that works. ka |