Re: python-ldap on PyPI

[<mi...@st...>]

Torsten Kurbad wrote:
> 
> I just created a first .egg of python-ldap.

Thanks for contributing this.

> Using a standard Linux distribution, like Gentoo,

Hmm, all modifications to setup.py should work on Windows either.

> 1. If not already done so, follow the instructions at
> http://peak.telecommunity.com/DevCenter/EasyInstall#installing-easy-install

Is it a MUST?

> -from distutils.core import setup, Extension
> +from setuptools import setup, Extension, find_packages

Hmm, this replaces distutils completely. Isn't there any pattern for a
fall-back to distutils if setuptools is not available?

> +if float(sys.version[:3]) < 2.3:
> +    packages = find_packages('ldap', 'ldap.schema')
> [..]
>  	#-- Python packages (doesn't work with Python prior 2.3)
> -#	packages = ['ldap', 'ldap.schema'],
> +        packages = packages,

And how to build that with Python 2.2 and earlier?

> +        platforms = ['posix']

Shouldn't that be derived from sys.platform during build?
Or at least to be defined in setup.cfg. That's what it's for.

For now I consider your patch to solve the .egg thingy for you. I won't
patch the general setup.py in standard source distribution. I might add
your version of setup.py as setup_egg.py under Build/ in the source
distribution.

Ciao, Michael.