[python-control-developers] [python-control/python-control] d61e6d: fix color cycling not working in singular_values_plot

[Richard M. <no...@gi...>]

  Branch: refs/heads/main
  Home:   https://github.com/python-control/python-control
  Commit: d61e6d4f17afe7b80153e71f4f4d734a83d9b5cf
      https://github.com/python-control/python-control/commit/d61e6d4f17afe7b80153e71f4f4d734a83d9b5cf
  Author: Lorenz Kies <lor...@gm...>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M control/freqplot.py

  Log Message:
  -----------
  fix color cycling not working in singular_values_plot

this seems to have ben caused by a name collision between the function scope color variable and the loop-"local" color variable.
the first time _get_color is called it will replace the function level color so in the next iteration a color is explicitly passed to _get_color so it will no longer automatically cycle through colors.


  Commit: 049a71657fb348214dd4972d9b53183389a2240a
      https://github.com/python-control/python-control/commit/049a71657fb348214dd4972d9b53183389a2240a
  Author: Lorenz Kies <lor...@gm...>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M control/tests/freqplot_test.py

  Log Message:
  -----------
  test to verify that color cycling works for singular_values_plot


  Commit: ad996f9b4961ba1b741fd302949b5c271cf01f84
      https://github.com/python-control/python-control/commit/ad996f9b4961ba1b741fd302949b5c271cf01f84
  Author: Richard Murray <mu...@cd...>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M control/freqplot.py
    M control/tests/freqplot_test.py

  Log Message:
  -----------
  Merge pull request #1138 from lkies/fix-svp

Fix color cycling not working in singular_values_plot


Compare: https://github.com/python-control/python-control/compare/45a6a2af66db...ad996f9b4961

To unsubscribe from these emails, change your notification settings at https://github.com/python-control/python-control/settings/notifications