Menu
▾
▴
[python-control-developers] [python-control/python-control] d5156e: Lint: remove unused variables, or prefix with `_`
|
From: Richard M. <no...@gi...> - 2025-02-19 06:12:39
|
Branch: refs/heads/main Home: https://github.com/python-control/python-control Commit: d5156e574241c4697960afe097e2884edd4f83f9 https://github.com/python-control/python-control/commit/d5156e574241c4697960afe097e2884edd4f83f9 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/bdalg_test.py M control/tests/bspline_test.py M control/tests/ctrlplot_test.py M control/tests/descfcn_test.py M control/tests/discrete_test.py M control/tests/flatsys_test.py M control/tests/frd_test.py M control/tests/freqplot_test.py M control/tests/interconnect_test.py M control/tests/iosys_test.py M control/tests/lti_test.py M control/tests/matlab_test.py M control/tests/namedio_test.py M control/tests/nlsys_test.py M control/tests/nyquist_test.py M control/tests/optimal_test.py M control/tests/phaseplot_test.py M control/tests/pzmap_test.py M control/tests/statefbk_test.py M control/tests/statesp_test.py M control/tests/stochsys_test.py M control/tests/timeplot_test.py M control/tests/timeresp_test.py M control/tests/trdata_test.py Log Message: ----------- Lint: remove unused variables, or prefix with `_` Where it's clear that function is called for side effects (e.g., in a q`with pytest.raises` block), don't assign function output. Where it's not clear, e.g., binary ops on LTI objects, call result `_sys` or similar. There are plenty of in-between cases: for those I chose based on understandability. Commit: 2a1833171a3e0abf2584246d909e80178780ecd5 https://github.com/python-control/python-control/commit/2a1833171a3e0abf2584246d909e80178780ecd5 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/bspline_test.py M control/tests/conftest.py M control/tests/frd_test.py M control/tests/freqplot_test.py M control/tests/interconnect_test.py M control/tests/iosys_test.py M control/tests/kwargs_test.py M control/tests/lti_test.py M control/tests/matlab2_test.py M control/tests/modelsimp_test.py M control/tests/namedio_test.py M control/tests/phaseplot_test.py M control/tests/rlocus_test.py M control/tests/statesp_test.py M control/tests/stochsys_test.py M control/tests/timeplot_test.py M control/tests/timeresp_test.py Log Message: ----------- Remove unused imports Where imports were test fixtures, replaced with `@pytest.mark.usefixtures('nameoffixture')`. Commit: 1bc01197004d3055e9348b29304b323fba4c4399 https://github.com/python-control/python-control/commit/1bc01197004d3055e9348b29304b323fba4c4399 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/config_test.py M control/tests/namedio_test.py Log Message: ----------- Remove imports needed for `eval` Provide relevant symbols via `locals` argument to eval. Commit: df756eb9b3da3bfe8a66105bd680b8127e952595 https://github.com/python-control/python-control/commit/df756eb9b3da3bfe8a66105bd680b8127e952595 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/ctrlplot_test.py M control/tests/docstrings_test.py Log Message: ----------- Fix incorrect variable names in f-strings Commit: 48d61950a419487be70b5061e66b703d9fc2ec2a https://github.com/python-control/python-control/commit/48d61950a419487be70b5061e66b703d9fc2ec2a Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M pyproject.toml Log Message: ----------- Apply ruff checks to control/tests/ Commit: 20f4b7660b28479c16a48839d29bc251181d4482 https://github.com/python-control/python-control/commit/20f4b7660b28479c16a48839d29bc251181d4482 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/docstrings_test.py Log Message: ----------- Remove unused variable fail_if_missing in test_parameter_docs Commit: 3729d8912deddd482fa10086a3d32d47ad33ba8a https://github.com/python-control/python-control/commit/3729d8912deddd482fa10086a3d32d47ad33ba8a Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/docstrings_test.py Log Message: ----------- Remove unused obj and objname in test_iosys_attribute_lists Commit: 36d5e8a6800632669d45328825c8cbcdc8642802 https://github.com/python-control/python-control/commit/36d5e8a6800632669d45328825c8cbcdc8642802 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/docstrings_test.py Log Message: ----------- Remove unused variable docstring in test_iosys_container_classes Commit: 7fe9d4ef4f5db9bbb3bf7894a59ae820b407b6ac https://github.com/python-control/python-control/commit/7fe9d4ef4f5db9bbb3bf7894a59ae820b407b6ac Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/kwargs_test.py Log Message: ----------- Import numpy for symbol np.array Symbol reference in lambda which is never called. Commit: ba33c21e01e220b1587244ecbe76130aa936681e https://github.com/python-control/python-control/commit/ba33c21e01e220b1587244ecbe76130aa936681e Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/frd_test.py Log Message: ----------- Remove ineffective testFeedback2 in frd_test.py The test had no assertions, but have been intended to test MIMO feedback; for this see testMIMOfb in same file. Commit: 2156adf276a2a971393bc49b5ab054aeaa246da6 https://github.com/python-control/python-control/commit/2156adf276a2a971393bc49b5ab054aeaa246da6 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/matlab_test.py Log Message: ----------- Add assertion in testUnwrap in matlab_test Commit: 69afb8266eb5e4633e8a77c9c592307577c8eb9e https://github.com/python-control/python-control/commit/69afb8266eb5e4633e8a77c9c592307577c8eb9e Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/optimal_test.py Log Message: ----------- Remove unused steady-state output variable Commit: 4e0b9c1a4447a939c775e6916dcf9246fa46e345 https://github.com/python-control/python-control/commit/4e0b9c1a4447a939c775e6916dcf9246fa46e345 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/rlocus_test.py Log Message: ----------- Mark unused test function with noqa The function doesn't exist, but the test is never called. Commit: 36541635ad5e92a017cb46596d70fd1cc0ecaf86 https://github.com/python-control/python-control/commit/36541635ad5e92a017cb46596d70fd1cc0ecaf86 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/config.py M control/flatsys/flatsys.py M control/nlsys.py M control/optimal.py M control/phaseplot.py M control/statesp.py M control/tests/docstrings_test.py M control/tests/iosys_test.py M control/tests/kwargs_test.py M control/tests/phaseplot_test.py M control/tests/statesp_test.py M control/tests/stochsys_test.py M control/tests/timeresp_test.py M control/timeresp.py M doc/develop.rst M doc/iosys.rst M doc/optimal.rst M doc/stochastic.rst Log Message: ----------- Merge remote-tracking branch 'upstream/main' into lint-tests Commit: 2d5738a957c6dd46d4ee723cea7d521ff8a9b381 https://github.com/python-control/python-control/commit/2d5738a957c6dd46d4ee723cea7d521ff8a9b381 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/timeresp_test.py Log Message: ----------- Fix bugs and lint errors in test_timeresp_aliases Commit: fb0519cd2a7347dc8effaf3ba6fc17b7c0aec878 https://github.com/python-control/python-control/commit/fb0519cd2a7347dc8effaf3ba6fc17b7c0aec878 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/statesp_test.py Log Message: ----------- Correct use of slycotonly in statesp_test.py slycontonly is not a fixture. Commit: c6d26f1c8c63e4dee8621c305bb7176a5899754a https://github.com/python-control/python-control/commit/c6d26f1c8c63e4dee8621c305bb7176a5899754a Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/frd_test.py Log Message: ----------- Remove unused ss_{siso,mimo} variables It looks like a block of code was copied-and-pasted between two test functions; removed the unused variable in each case. Commit: 22db2bfffe9ef012a89d028c59c87800b90b2279 https://github.com/python-control/python-control/commit/22db2bfffe9ef012a89d028c59c87800b90b2279 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/config_test.py M control/tests/namedio_test.py Log Message: ----------- Don't use keyword args for eval Only works from Python 3.13. Commit: 5ff3c0c17c9954e3d388c5585a6aebf2f396f324 https://github.com/python-control/python-control/commit/5ff3c0c17c9954e3d388c5585a6aebf2f396f324 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M .github/workflows/python-package-conda.yml Log Message: ----------- Handle deprecation warnings from conda setup in Github actions Commit: 51eb00a99feb751bb4afc2a4f9dae3b54a36eae1 https://github.com/python-control/python-control/commit/51eb00a99feb751bb4afc2a4f9dae3b54a36eae1 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/kwargs_test.py Log Message: ----------- Remove redundant kwarg test entries Commit: e29ba64324f8d15f3e026166d00f8c15665414ce https://github.com/python-control/python-control/commit/e29ba64324f8d15f3e026166d00f8c15665414ce Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/modelsimp_test.py Log Message: ----------- Add assertion to check result of markov call Commit: ff4d7b68e3358b918146dfc51c75edb64275262a https://github.com/python-control/python-control/commit/ff4d7b68e3358b918146dfc51c75edb64275262a Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/tests/optimal_test.py Log Message: ----------- Remove unused variables in test_optimal_doc Commit: 870fa196083a0050c05814c702afeb6226c5b046 https://github.com/python-control/python-control/commit/870fa196083a0050c05814c702afeb6226c5b046 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M control/phaseplot.py M control/tests/ctrlplot_test.py M control/tests/kwargs_test.py M control/tests/phaseplot_test.py M doc/figures/phaseplot-dampedosc-default.png M doc/figures/phaseplot-invpend-meshgrid.png M doc/figures/phaseplot-oscillator-helpers.png M doc/functions.rst M doc/phaseplot.rst M examples/phase_plane_plots.py M examples/plot_gallery.py Log Message: ----------- Merge remote-tracking branch 'upstream/main' into lint-tests Commit: c907a4fc396e3c534b9d465b074ee35a959c3605 https://github.com/python-control/python-control/commit/c907a4fc396e3c534b9d465b074ee35a959c3605 Author: Rory Yorke <ror...@gm...> Date: 2025-02-16 (Sun, 16 Feb 2025) Changed paths: M .github/workflows/python-package-conda.yml Log Message: ----------- Revert "Handle deprecation warnings from conda setup in Github actions" This reverts commit 5ff3c0c17c9954e3d388c5585a6aebf2f396f324. Commit: f6799ab8e60d7fcd4b02d52d5903f08c24957faf https://github.com/python-control/python-control/commit/f6799ab8e60d7fcd4b02d52d5903f08c24957faf Author: Richard Murray <mu...@cd...> Date: 2025-02-18 (Tue, 18 Feb 2025) Changed paths: M control/tests/bdalg_test.py M control/tests/bspline_test.py M control/tests/config_test.py M control/tests/conftest.py M control/tests/ctrlplot_test.py M control/tests/descfcn_test.py M control/tests/discrete_test.py M control/tests/docstrings_test.py M control/tests/flatsys_test.py M control/tests/frd_test.py M control/tests/freqplot_test.py M control/tests/interconnect_test.py M control/tests/iosys_test.py M control/tests/kwargs_test.py M control/tests/lti_test.py M control/tests/matlab2_test.py M control/tests/matlab_test.py M control/tests/modelsimp_test.py M control/tests/namedio_test.py M control/tests/nlsys_test.py M control/tests/nyquist_test.py M control/tests/optimal_test.py M control/tests/phaseplot_test.py M control/tests/pzmap_test.py M control/tests/rlocus_test.py M control/tests/statefbk_test.py M control/tests/statesp_test.py M control/tests/stochsys_test.py M control/tests/timeplot_test.py M control/tests/timeresp_test.py M control/tests/trdata_test.py M pyproject.toml Log Message: ----------- Merge pull request #1127 from roryyorke/lint-tests Lint tests Compare: https://github.com/python-control/python-control/compare/d11f05dbadd8...f6799ab8e60d To unsubscribe from these emails, change your notification settings at https://github.com/python-control/python-control/settings/notifications |
