Re: [python-control-discuss] [BULK] fix to ctrlutil.unwrap

[Richard M. <mu...@cd...>]

If you are going to make minor changes, I think it is fine to just do them in trunk.  The main guideline is to make sure that you don't commit changes to trunk that break the test cases.  As we convert to v0.4a (which I hope to make the default in a few weeks, if I can find the time), we'll start having easier ways to run the test suite.

If you are going to do something substantial (ala the Princeton group changes), then you should create a branch (eg, "svn cp trunk branches/murray-24Mar11") and work there.  When everything is working, we can merge the changes in the branch with trunk.

Right now the density of work is sparse enough that I don't think we need to do too much to keep branches separate, etc, but if someone has suggestions on simple things to do that might improve our productivity, just send comments to the list.  

-richard

On 21 Mar 2011, at 18:11 , Sawyer Fuller wrote:

> also, any procedures you can point me to regarding etiquette? i haven't ever developed in a team before. Is there a branch i should commit to? is there a post somewhere that addresses how to contribute? 
> 
> ------------------------
> Sawyer B. Fuller
> California Institute of Technology
> http://www.cds.caltech.edu/~minster/
> 
> 
> 
> 
> On Mon, Mar 21, 2011 at 6:07 PM, Sawyer Fuller <mi...@ca...> wrote:
> cool
> 
> it's blinkminster
> 
> ------------------------
> Sawyer B. Fuller
> California Institute of Technology
> http://www.cds.caltech.edu/~minster/
> 
> 
> 
> 
> On Mon, Mar 21, 2011 at 2:53 AM, Richard Murray <mu...@cd...> wrote:
> What's your sourceforge id?  I can add it to the list of people who can commit.
> 
> -richard
> 
> On 20 Mar 2011, at 18:23 , Sawyer Fuller wrote:
> 
> > hey, i've a quick fix to ctrlutil.unwrap to make it successfully unwrap phase changes of greater than 4pi:
> >
> > in this section:
> >
> >     for k in range(len(angle)):
> >         # See if we need to account for angle wrapping
> >         if (angle[k] - last > period/2):
> >             wrap = -period
> >         elif (last - angle[k] > period/2):
> >             wrap = period
> >
> > i've replaced setting the wrap value with incrementing it:
> >
> >     for k in range(len(angle)):
> >         # See if we need to account for angle wrapping
> >         if (angle[k] - last > period/2):
> >             wrap -= period
> >         elif (last - angle[k] > period/2):
> >             wrap += period
> >
> > also, what's the procedure for getting commit access to the repository?
> >
> > ------------------------
> > Sawyer B. Fuller
> > California Institute of Technology
> > http://www.cds.caltech.edu/~minster/
> >
> >
> > ------------------------------------------------------------------------------
> > Colocation vs. Managed Hosting
> > A question and answer guide to determining the best fit
> > for your organization - today and in the future.
> > http://p.sf.net/sfu/internap-sfd2d_______________________________________________
> > python-control-discuss mailing list
> > pyt...@li...
> > https://lists.sourceforge.net/lists/listinfo/python-control-discuss
> 
> 
>