[Pypgsql-devel] [ pypgsql-Bugs-1006782 ] pyPGSQL does not connect to PostgreSQL 8.0 Beta

[SourceForge.net <no...@so...>]

Bugs item #1006782, was opened at 2004-08-10 13:49
Message generated for change (Comment added) made by jfmeinel
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=1006782&group_id=16528

Category: libpq
Group: None
Status: Pending
Resolution: Fixed
Priority: 5
Submitted By: Harald Armin Massa (ghum)
Assigned to: Nobody/Anonymous (nobody)
Summary: pyPGSQL does not connect to PostgreSQL 8.0 Beta

Initial Comment:
While trying to connect to Postgresql 8.0, PyPGSQL raises

Invalid format for PgVersion construction.


Error. That's seems to be within 

PyObject *PgVersion_New(char *version)

of pgversion.c


What is going wrong?

----------------------------------------------------------------------

Comment By: John F Meinel Jr (jfmeinel)
Date: 2005-02-20 23:12

Message:
Logged In: YES 
user_id=266114

Well, actually this was only a problem when postgres was
beta. For a full release, we would be okay, since the
version string changes to something that you are okay with.

However, it still fails with some other installations. For
instance, Red Hat Enterprise Linux 3 (RHEL3) installs the
Redhat Database (it may be modified), but the version string
is something like 7.4-RH, which also isn't beta, alpha,
devel, etc.

Is there a reason you have to be so strict about the
version? Can't you just accept anything that can be parsed
as Number.Number? Is there something else that uses the
version (like do you change how queries are structured?)

Thanks for looking into it, though. And it would be nice to
get a fresh release with some of the fixes. (Though I think
when I tried CVS head, I ran into problems because of some
of the other changes that were made.)


----------------------------------------------------------------------

Comment By: Gerhard Häring (ghaering)
Date: 2004-10-05 03:11

Message:
Logged In: YES 
user_id=163326

Looks like it's time to get a few bugs fixed and make a
release that will work with Pg8.

----------------------------------------------------------------------

Comment By: John F Meinel Jr (jfmeinel)
Date: 2004-09-08 11:26

Message:
Logged In: YES 
user_id=266114

I am unable to build from source. I have Visual Studio 7.1,
and not 6 to compile the library.

Can you run "py setup.py bdist_wininst" for me and either
post the installer, or send it to me?

Thanks,
John
=:->

----------------------------------------------------------------------

Comment By: Harald Armin Massa (ghum)
Date: 2004-08-25 06:20

Message:
Logged In: YES 
user_id=665785

correcting myself...

if (pgstricmp(last, "beta") == 0)
    return (errno != 0);

pgstricmp does not take any length parameter 



----------------------------------------------------------------------

Comment By: Harald Armin Massa (ghum)
Date: 2004-08-25 06:20

Message:
Logged In: YES 
user_id=665785

correcting myself...

if (pgstricmp(last, "beta") == 0)
    return (errno != 0);

pgstricmp does not take any length parameter 



----------------------------------------------------------------------

Comment By: Harald Armin Massa (ghum)
Date: 2004-08-25 06:19

Message:
Logged In: YES 
user_id=665785

Thank you very much, mfuhr... 

I looked at the "devel" check and propose to do 

if (pgstricmp(last, "beta", 4) == 0)
    return (errno != 0);
    
instead of strncmp ... I suppose the PostgreSQL developers
had their reason to provide their own strcmp, or?



----------------------------------------------------------------------

Comment By: Michael Fuhr (mfuhr)
Date: 2004-08-23 22:47

Message:
Logged In: YES 
user_id=655499

PgVersion_New() calls parseToken(), which doesn't allow for
the string "beta" in the last token of "8.0.0beta1". 
parseToken() checks for "devel" and a few other cases, but
not for "beta".  I got it to work by adding the following
lines after the check for "devel":

if (strncmp(last, "beta", 4) == 0)
    return (errno != 0);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116528&aid=1006782&group_id=16528