Menu
▾
▴
[Pypgsql-devel] [ pypgsql-Patches-484468 ] Draft Unicode patch
|
From: <no...@so...> - 2002-10-27 04:02:27
|
Patches item #484468, was opened at 2001-11-22 07:04 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=316528&aid=484468&group_id=16528 Category: None Group: None >Status: Closed Resolution: Accepted Priority: 5 Submitted By: Gerhard Häring (ghaering) Assigned to: Gerhard Häring (ghaering) Summary: Draft Unicode patch Initial Comment: Ok, here comes what I've done so far for adding Unicode support. Jjust to show what I've been talking about on the mailing list and by no means finished or bugfree. Bugs are (at least): - no checks if PostgreSQL multibyte support is available at all (compiles may perhaps fail) - for some reason, no exception is raised when setting the clientencoding fails ---------------------------------------------------------------------- >Comment By: Gerhard Häring (ghaering) Date: 2002-10-27 05:02 Message: Logged In: YES user_id=163326 Applied in revision 1.18 of PgSQL.py. ---------------------------------------------------------------------- Comment By: Gerhard Häring (ghaering) Date: 2002-10-03 16:31 Message: Logged In: YES user_id=163326 The patch still applies cleanly to pyPgSQL 2.2. ---------------------------------------------------------------------- Comment By: Gerhard Häring (ghaering) Date: 2002-06-05 19:32 Message: Logged In: YES user_id=163326 I've now uploaded an updated patch that applies cleanly to pyPgSQL version 2.1. I'd be very grateful if those interested in Unicode support could test it and tell me (on the mailing list, preferrably) what should be done differently and which features are still missing, if any. ---------------------------------------------------------------------- Comment By: Gerhard Häring (ghaering) Date: 2002-04-16 05:18 Message: Logged In: YES user_id=163326 Hmm. The patch is pretty large. So one more comment: The only relevant addition is the __unicodeConvert() method in the Connection class. The other relevant changes can be found by grepping for "unicode". There's also cosmetic changes to the typechecking in this patch (always use "is" instead of "==" and "is not" instead of "!="). And also always compare to "None" with "is" - the comparison with "==" has bitten a pyPgSQL user once. The is-Check is more pythonic and slightly faster. Enough for today :) ---------------------------------------------------------------------- Comment By: Gerhard Häring (ghaering) Date: 2002-04-16 05:06 Message: Logged In: YES user_id=163326 I'm publishing here my update to the patch. This patch is against the latest CVS version of pyPgSQL. It turns out that changes to libpq are not necessary at all. Some testing code is already there and I'm pretty confident that I'm on the right track with the current approach. More later. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=316528&aid=484468&group_id=16528 |