[PyOpenGL-Devel] [ pyopengl-Bugs-528094 ] memory leak in glVertex2s

[<no...@so...>]

Bugs item #528094, was opened at 2002-03-10 06:51
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105988&aid=528094&group_id=5988

Category: GL
Group: v2.0
>Status: Pending
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: memory leak in glVertex2s

Initial Comment:
Hi, I installed PyOpenGL-2.0.0.44.win32-py2.2.exe.

I hunted a memleak in my app for some time and I 
finally fixed it: my app lost mem everytime it called 
glVertex2s.

glVertex2f and glVertex2sv are working fine though.

----------------------------------------------------------------------

>Comment By: Mike C. Fletcher (mcfletch)
Date: 2002-12-28 02:28

Message:
Logged In: YES 
user_id=34901

Ah well, I'll assume I got it right (I accidentally ;)
checked the change in), as it seems to work and be logical.

----------------------------------------------------------------------

Comment By: Mike C. Fletcher (mcfletch)
Date: 2002-12-27 21:41

Message:
Logged In: YES 
user_id=34901

I'm guessing this is the responsible code from
interface/simple_typemaps.inc (would be nice to have a
test-case BTW to be sure it's still a problem):

    $1= ($1_type)(PyInt_AsLong( PyNumber_Int($input) ));

Why is PyNumber_Int used, PyInt_AsLong attempts to do the
conversion anyway, and PyNumber_Int creates a _new_
reference (hence the leak)!

Rene, could you check that I haven't missed something C-ish
(or maybe some sort of weird Python-version problem?), and
if not, simply eliminate the PyNumber_Int call?

	if (PyInt_Check($input) || PyLong_Check($input))
	{
		$1= ($1_type)(PyInt_AsLong( $input ));
	}

PyOpenGL builds with the given change, but again, there
isn't a test for the condition to confirm that it actually
fixes the problem.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105988&aid=528094&group_id=5988