#13 swig_src/hankel_wrap.c:2894: possible bad if test ?

[dcb]

swig_src/hankel_wrap.c:2894:20: warning: comparison of constant 'GSL_FAILURE' (-1) with boolean expression is always false [-Wtautological-constant-out-of-range-compare]

if(GSL_FAILURE == PyGSL_ERROR_FLAG(result)){

[Pierre Schnizer]

No, as PyGSL_ERROR_FLAG can return an other value over PyGSL_error_flag

See pygsl/Include/error_flags.h line 86ff:
<snip>

define PyGSL_ERROR_FLAG(flag) \

(((long) flag == GSL_SUCCESS) && (!PyErr_Occurred())) ? GSL_SUCCESS
: \ PyGSL_error_flag((long) (flag))
</snip>

Thanks for the info
Pierre

On 07.09.2014 20:57, dcb wrote:

---

[bugs:#13] http://sourceforge.net/p/pygsl/bugs/13
swig_src/hankel_wrap.c:2894: possible bad if test ?

Status: open
Group: CVS_version
Created: Sun Sep 07, 2014 06:57 PM UTC by dcb
Last Updated: Sun Sep 07, 2014 06:57 PM UTC
Owner: nobody

swig_src/hankel_wrap.c:2894:20: warning: comparison of constant
'GSL_FAILURE' (-1) with boolean expression is always false
[-Wtautological-constant-out-of-range-compare]

if(GSL_FAILURE == PyGSL_ERROR_FLAG(result)){

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/pygsl/bugs/13/
https://sourceforge.net/p/pygsl/bugs/13

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/
https://sourceforge.net/auth/subscriptions

--
+---------------------------------------------------------------------+
Pierre Schnizer p.schnizer@gsi.de
Telephon : +49 6159 71 1557
Fax : +49 6159 71 3099

GSI Helmholtzzentrum für Schwerionenforschung GmbH
Planckstraße 1
64291 Darmstadt
www.gsi.de

Gesellschaft mit beschränkter Haftung
Sitz der Gesellschaft: Darmstadt
Handelsregister: Amtsgericht Darmstadt, HRB 1528

Geschäftsführung: Professor Dr. Dr. h.c. mult. Horst Stöcker
Peter Hassenbach

Vorsitzende des Aufsichtsrates: Dr. Beatrix Vierkorn-Rudolph
Stellvertreter: Ministerialdirigent Dr. Rolf Bernhardt
+---------------------------------------------------------------------+