Re: [pygcs-devel] Whiteboard changes

[Jeff B. <jef...@me...>]

> > Added ownership of whiteboard items per Klaus since we had gone
> > that far already.  Admin can erase all or any selected messages.
> > Normal users can only erase selected messages of theirs or 'wb_erase
> > all' which will erase all of theirs.  I didn't like the keyword
> > 'mine' anymore since that implies that there is a way for normal
> > users to erase other peoples'.
> 
> Given the way I structured the Whiteboard, that ought to have been
> easy, eh?  (Since the username is already tied to the message...)

Yep

> Btw, do you like the way that class was done?  Feedback is welcome,
> especially if you think it ought to change in some way.

Seems fine to me.  My only hesitation was (and it has nothing to do with
how your class was written or structured) where to embed the ownership
restriction for wb_erase and the Admin-can-override stuff.

> Hm.  At first look, it looks like you made 'erase all' into 'erase mine'.

Other way around.  I turned wb_erase mine into wb_erase all.

> If Admin does a wb_erase, it does the right thing.  If Admin does a
> 'wb_erase all', it only erases messages from Admin.
> 
> Want me to fix, or you?  It should be a trivial fix.

Go for it