Menu
▾
▴
Source Merge Request #5: Fixed a few bugs (rejected)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Cory Baumgart wants to merge 5 commits from /u/lpfreak1283/pydarts/ to master, 2020-04-26
Hi there!
I fixed a few bugs:
- Game wouldn't load when selecting options and pressing "ok". The inital database sql to load the game options in tries to load the players, but objGame is not defined yet, unless you were to have started a new game over again from a previous game. I moved the creation of that sql into the match creation after the inital objGame declaration. Fixed the problem immediately!
- I fixed the "cheating" option to allow choosing the bullseyes. I basically looked for the "backupbutton" dart stroke to come, which is tied to the letter "b", and forced the program to write a "b" and when pressing enter, chooses a bullseye (SB or DB)! Works like a charm!
| Commit | Date | |
|---|---|---|
|
[1ec3b6]
(HEAD, master)
by
LPFreak1283
Fixed error in CScores.py where a parenthesis was missing |
2020-04-24 16:31:53 | Tree |
| 2020-03-26 22:55:01 | Tree | |
| 2020-03-26 22:54:01 | Tree | |
| 2020-03-21 23:55:04 | Tree | |
| 2020-03-21 18:48:18 | Tree |
Hi Cory,
Thanks for contribution :)
To be sure to understand well, I'vre intergrated all your changes manually, so I am obliged to reject merge request I think.
I still don't understand why did you replace CURRENT_TIMESTAMP by datetime('now','localtime') ?
Could you tell me a bit more ?
CHeers !
I did that to get the correct date/time for my location (USA/NY). Otherwise it was showing in the database as the universal daye/time which would confuse those looking at the stats!
I would just reject the merge as orher commits have come through since i sent this over!
Thanks!
Ok that make sense, I keep it so.
Sorry for bad reactivity. I'll try to speed up next time :)