[pupnp-tracker] [ pupnp-Bugs-3063148 ] Change in comment for SetMaxContentLength in upnp.h

[Tracker i. u. n. <pup...@li...>]

Bugs item #3063148, was opened at 2010-09-09 18:35
Message generated for change (Tracker Item Submitted) made by inactiveneurons
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=841026&aid=3063148&group_id=166957

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Chandra (inactiveneurons)
Assigned to: Nobody/Anonymous (nobody)
Summary: Change in comment for SetMaxContentLength in upnp.h

Initial Comment:
Hello,

This is a follow up from issue 6 in tracker id 3056713: calling UpnpSetMaxContentLength() by passing '0' disables the content length checking. This is useful for developing some prototype applications that deal with a lot of XML/SOAP data, and for debugging. 

The corresponding c file change is already in the pupnp tree. Copy/pasting the relevant block of code here for clarity:

In upnp/src/genlib/net/http/httpreadwrite.c:

                                if (g_maxContentLength > 0 && parser->content_length > (unsigned int)g_maxContentLength) {
                                        *http_error_code = HTTP_REQ_ENTITY_TOO_LARGE;
                                        line = __LINE__;
                                        ret = UPNP_E_OUTOF_BOUNDS;
                                        goto ExitFunction;
                                }

This block of code checks only does the bounds check if g_maxContentLength > 0, and it's only place  g_maxContentLength is checked.

Attached is a patch against the latest sources.

Thanks,
Chandra

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=841026&aid=3063148&group_id=166957