Menu ▾ ▴

#7 bug in 'review model' functionality

4.0.2
fixed
Laure Ciernik
None
2019-05-31
2019-05-22
Eshref Yozdemir
No

Summary

When reviewing a model, one has the possibility to plot the data and the according events (i.e., Predicted & observed). In Version v.4.0.2 the plot won't show all the events, if there exists more than 7 conditions.
https://sourceforge.net/p/pspm/discussion/bugs/thread/c505516b0b/

Steps to Reproduce

  1. check if line 153 (for older revisions than 6667, line 146) in pspm_rev_glm contains: m = floor(j/cl);
  2. Try to review a GLM model which has more than 7 conditions

Expected Results

Each condition should be displayed and be marked with a color.

Actual Results

You will see that not all conditions are shown.

(Optional) Possible Cause and Solutions

The problem occurs when assigning different colors to the events for the plot. In some cases m becomes 0 and then an index out of bounds error occurs.
The solution is to replace 'm = floor(j/cl);' in line 153 (for older revisions than 6667, line 146) to 'm = floor((j-0.1)/cl);'

(Optional) Screenshots if Graphical User Interface is Used

Technical Info

  • PsPM revision ID: 606, v.4.0.2
  • MATLAB version: -

Discussion

  • Laure Ciernik

    Laure Ciernik - 2019-05-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,19 +1,23 @@
 ### Summary
+When reviewing a model, one has the possibility to plot the data and the according events (i.e., Predicted & observed). In Version v.4.0.2 the plot won't show all the events, if there exists more than 7 conditions. 
 https://sourceforge.net/p/pspm/discussion/bugs/thread/c505516b0b/

 ### Steps to Reproduce
-1.
-2.
-3.
+1. check if line 153 (for older revisions than 6667, line 146) in pspm_rev_glm contains: m = floor(j/cl);
+2. Try to review a GLM model which has more than 7 conditions

 ### Expected Results
+Each condition should be displayed and be marked with a color. 

 ### Actual Results
+You will see that not all conditions are shown.

 ### (Optional) Possible Cause and Solutions
+The problem occurs when assigning different colors to the events for the plot. In some cases m becomes 0 and then an index out of bounds error occurs. 
+The solution is to replace 'm = floor(j/cl);' in line 153 (for older revisions than 6667, line 146) to 'm = floor((j-0.1)/cl);'

 ### (Optional) Screenshots if Graphical User Interface is Used

 ### Technical Info
-* PsPM revision ID:
-* MATLAB version:
+* PsPM revision ID:  606, v.4.0.2 
+* MATLAB version: -
    • status: open --> fixed
    • Milestone: 4.1.0 --> 4.0.2
     

  • Eshref Yozdemir

    Eshref Yozdemir - 2019-05-31
    • assigned_to: Laure Ciernik
     

Log in to post a comment.

veeam logo