#5 limit changes and split

[wilk]

It's not really bug, but it can lock channel when the configuration still remains correct. It is visible when split begins and ends.

My config is:

pre-0.2.3-final-compat OFF
pre-0.2.11-final-compat OFF
limit ON
limit-time 2m
limit-time-up 2m
limit-time-down 30s
limit-offset 5
limit-bots 1
limit-tolerance 50%
owner-limit-time 1m

There is such situation:

152548 -!- user1 has quit [*.club-internet.fr *.nl]
152548 -!- user2 has quit [*.club-internet.fr *.nl]
152549 -!- user3 has quit [*.club-internet.fr ircnet.demon.co.uk]
152549 -!- user4 has quit [*.club-internet.fr ircnet.demon.co.uk]
152549 -!- user6 has quit [*.club-internet.fr ircnet.demon.co.uk]
152549 -!- bot3 has quit [*.club-internet.fr ircnet.demon.co.uk]
152549 -!- user5 has quit [*.club-internet.fr ircnet.demon.co.uk]

* correct 30s as in limit-time-down

152618 -!- mode/#chan [+l 68] by bot1
152619 -!- mode/#chan [+l 68] by bot2

152821 -!- user7 has quit [Ping timeout]
152921 -!- bot3 has joined #chan
152921 -!- user6 has joined #chan
152921 -!- user4 has joined #chan
152921 -!- ServerMode/#chan [+ooo bot3 user6 user4] by hub.uk.ircnet.org
152921 -!- user5 has joined #chan
152921 -!- user3 has joined #chan
152921 -!- ServerMode/#chan [+o user5] by hub.uk.ircnet.org
152921 -!- ServerMode/#chan [+l 10] by hub.uk.ircnet.org

* bad delay - 1m. it is because of 15:29:21 + owner-limit-time, but it is incorrect and takes too much time so it locks channel for 1 minute (for my config)

153021 -!- mode/#chan [+l 72] by bot4
153021 -!- mode/#chan [+l 72] by bot5
153022 -!- mode/#chan [+l 72] by bot6

153024 -!- user8 has quit [""]
153111 -!- user1 has joined #chan
153111 -!- user2 has joined #chan
153111 -!- ServerMode/#chan [+vv user1 user2] by *.nl
153111 -!- ServerMode/#chan [+l 78] by *.nl

* correct - 1m, because of 15:31:11 + owner-limit-time, but not locking channel

153211 -!- mode/#chan [+l 73] by bot4
153211 -!- mode/#chan [+l 73] by bot2
153211 -!- mode/#chan [+l 73] by bot5

- when split starts, bots correctly set up a lower limit
- when split ends:
- limit from split is lower, bots raise it after too long time and it locks channel till that
- limit from split is higher, bots lower it correctly

limit-time-down is used only in gotPart method, bots should use it also when split-limit is lower than needed, and limit-time-up should be used when split-limit is too high, than owner-limit-time, for example:

- join, split-limit-higher - use limit-time-up
- part, quit, split-limit-lower - use limit-time-down
- owner-limit-change - use owner-limit-time

so it could prevent channel lock. Or just add variable server-limit-time (default value could be 15s), because it is mistake to use owner-limit-time for servers (i just found it because of reading the source code, at first i didn't know why there was 1m delay). And i know that you say that it would be another config option... but it is good, worst case is when there are none or too few options to configure. So it would be:

- join - use limit-time-up
- part (split), quit - use limit-time-down
- server limit change - use server-limit-time
- owner limit change - use owner-limit-time

[paladin]

Logged In: YES
user_id=1761016
Originator: NO

i think this is a desync problem.
the bots on difference ircservers see not the selve numbers of users/bots that are in the channel.

[wilk]

Logged In: YES
user_id=1797434
Originator: YES

There is nothing to do with desynch. Limit values are correctly set. It's about time to correct the limit. At first i didn't know why there was 1m delay, later i checked the code and saw that owner-limit-time (which i use strictly for owners management) is used also on event when server changes a limit. Owner-limit-time should be used only for limit management by owners, when this value is too big it can lock-up a channel when server changed limit below number of users. When this value is used also for server limit it makes it quite useless (i prefer to always set it at low value because of locking threat). It's now more like feature request..

[grusin]

Logged In: YES
user_id=1278790
Originator: NO

what's the value of backup-mode-delay?

[wilk]

Logged In: YES
user_id=1797434
Originator: YES

set: backup-mode-delay 7s

but this report is not about setting +l by few bots (look myTurn flaw bug report), but about using owner-limit-change for after split server's limit auto-changes