Menu ▾ ▴

#610 'Stack size becomes negative after instruction swap' Exception

v5.2
closed-fixed
None
5
2016-10-23
2016-06-02
No

Optimazation in proguard fails on next bytecode:

public final class ElvisKt {


  // access flags 0x19
  public final static concat(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;
   L0
    ALOAD 0
    LDC "s"
    INVOKESTATIC kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull (Ljava/lang/Object;Ljava/lang/String;)V
    ALOAD 1
    LDC "z"
    INVOKESTATIC kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull (Ljava/lang/Object;Ljava/lang/String;)V
   L1
    LINENUMBER 7 L1
    NEW java/lang/StringBuilder
    DUP
    INVOKESPECIAL java/lang/StringBuilder.<init> ()V
    ALOAD 0
    INVOKEVIRTUAL java/lang/StringBuilder.append (Ljava/lang/String;)Ljava/lang/StringBuilder;
    ALOAD 1
    INVOKEVIRTUAL java/lang/StringBuilder.append (Ljava/lang/String;)Ljava/lang/StringBuilder;
    INVOKEVIRTUAL java/lang/StringBuilder.toString ()Ljava/lang/String;
    ARETURN
   L2
    LOCALVARIABLE s Ljava/lang/String; L0 L2 0
    LOCALVARIABLE z Ljava/lang/String; L0 L2 1
    MAXSTACK = 2
    MAXLOCALS = 2

  // access flags 0x1A
  private final static doWork(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;    
   L0
    LINENUMBER 11 L0
    ALOAD 0
    ALOAD 1
    IFNONNULL L1
    LDC ""
    SWAP
    POP
    ARETURN
   L2
   L1
    ALOAD 1
   L3
    INVOKESTATIC ElvisKt.concat (Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;
    ARETURN
   L4
    LOCALVARIABLE $receiver Ljava/lang/String; L0 L4 0
    LOCALVARIABLE other Ljava/lang/String; L0 L4 1
    MAXSTACK = 2
    MAXLOCALS = 2

  // access flags 0x19
  public final static main([Ljava/lang/String;)V    
   L0
    ALOAD 0
    LDC "args"
    INVOKESTATIC kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull (Ljava/lang/Object;Ljava/lang/String;)V
   L1
    LINENUMBER 15 L1
    ALOAD 0
    ICONST_0
    AALOAD
    DUP
    IFNONNULL L2
    INVOKESTATIC kotlin/jvm/internal/Intrinsics.throwNpe ()V
   L2
    ALOAD 0
    ICONST_1
    AALOAD
    INVOKESTATIC ElvisKt.doWork (Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;
    POP
   L3
    LINENUMBER 16 L3
    RETURN
   L4
    LOCALVARIABLE args [Ljava/lang/String; L0 L4 0
    MAXSTACK = 3
    MAXLOCALS = 1

  // compiled from: elvis.kt
}

with

Unexpected error while computing stack sizes:
  Class       = [ElvisKt]
  Method      = [main([Ljava/lang/String;)V]
  Exception   = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
Unexpected error while inlining method:
  Target class   = [ElvisKt]
  Target method  = [main([Ljava/lang/String;)V]
  Exception      = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
java.lang.IllegalArgumentException: Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V]
    at proguard.classfile.attribute.visitor.StackSizeComputer.evaluateInstructionBlock(StackSizeComputer.java:334)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitBranchInstruction(StackSizeComputer.java:197)
    at proguard.classfile.instruction.BranchInstruction.accept(BranchInstruction.java:140)
    at proguard.classfile.attribute.visitor.StackSizeComputer.evaluateInstructionBlock(StackSizeComputer.java:355)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitCodeAttribute0(StackSizeComputer.java:153)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitCodeAttribute(StackSizeComputer.java:110)
    at proguard.optimize.peephole.MethodInliner.visitCodeAttribute0(MethodInliner.java:200)
    at proguard.optimize.peephole.MethodInliner.visitCodeAttribute(MethodInliner.java:152)
    at proguard.classfile.attribute.CodeAttribute.accept(CodeAttribute.java:101)
    at proguard.classfile.ProgramMethod.attributesAccept(ProgramMethod.java:79)
    at proguard.classfile.attribute.visitor.AllAttributeVisitor.visitProgramMember(AllAttributeVisitor.java:95)
    at proguard.classfile.util.SimplifiedVisitor.visitProgramMethod(SimplifiedVisitor.java:92)
    at proguard.classfile.ProgramMethod.accept(ProgramMethod.java:71)
    at proguard.classfile.ProgramClass.methodsAccept(ProgramClass.java:516)
    at proguard.classfile.visitor.AllMethodVisitor.visitProgramClass(AllMethodVisitor.java:47)
    at proguard.classfile.ProgramClass.accept(ProgramClass.java:358)
    at proguard.classfile.ClassPool.classesAccept(ClassPool.java:124)
    at proguard.optimize.Optimizer.execute(Optimizer.java:750)
    at proguard.ProGuard.optimize(ProGuard.java:328)
    at proguard.ProGuard.execute(ProGuard.java:127)
    at proguard.ProGuard.main(ProGuard.java:538)
Not inlining this method
Unexpected error while computing stack sizes:
  Class       = [ElvisKt]
  Method      = [main([Ljava/lang/String;)V]
  Exception   = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
Unexpected error while inlining method:
  Target class   = [ElvisKt]
  Target method  = [main([Ljava/lang/String;)V]
  Exception      = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
java.lang.IllegalArgumentException: Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V]
    at proguard.classfile.attribute.visitor.StackSizeComputer.evaluateInstructionBlock(StackSizeComputer.java:334)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitBranchInstruction(StackSizeComputer.java:197)
    at proguard.classfile.instruction.BranchInstruction.accept(BranchInstruction.java:140)
    at proguard.classfile.attribute.visitor.StackSizeComputer.evaluateInstructionBlock(StackSizeComputer.java:355)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitCodeAttribute0(StackSizeComputer.java:153)
    at proguard.classfile.attribute.visitor.StackSizeComputer.visitCodeAttribute(StackSizeComputer.java:110)
    at proguard.optimize.peephole.MethodInliner.visitCodeAttribute0(MethodInliner.java:200)
    at proguard.optimize.peephole.MethodInliner.visitCodeAttribute(MethodInliner.java:152)
    at proguard.classfile.attribute.CodeAttribute.accept(CodeAttribute.java:101)
    at proguard.classfile.ProgramMethod.attributesAccept(ProgramMethod.java:79)
    at proguard.classfile.attribute.visitor.AllAttributeVisitor.visitProgramMember(AllAttributeVisitor.java:95)
    at proguard.classfile.util.SimplifiedVisitor.visitProgramMethod(SimplifiedVisitor.java:92)
    at proguard.classfile.ProgramMethod.accept(ProgramMethod.java:71)
    at proguard.classfile.ProgramClass.methodsAccept(ProgramClass.java:516)
    at proguard.classfile.visitor.AllMethodVisitor.visitProgramClass(AllMethodVisitor.java:47)
    at proguard.classfile.ProgramClass.accept(ProgramClass.java:358)
    at proguard.classfile.ClassPool.classesAccept(ClassPool.java:124)
    at proguard.optimize.Optimizer.execute(Optimizer.java:762)
    at proguard.ProGuard.optimize(ProGuard.java:328)
    at proguard.ProGuard.execute(ProGuard.java:127)
    at proguard.ProGuard.main(ProGuard.java:538)
Not inlining this method
Unexpected error while computing stack sizes:
  Class       = [ElvisKt]
  Method      = [main([Ljava/lang/String;)V]
  Exception   = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
Unexpected error while editing code:
  Class       = [ElvisKt]
  Method      = [main([Ljava/lang/String;)V]
  Exception   = [java.lang.IllegalArgumentException] (Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V])
Error: Stack size becomes negative after instruction [24] swap in [ElvisKt.main([Ljava/lang/String;)V]

Confuguration file:
-injars unnamed.jar
-outjars myapplication_out.jar
-libraryjars <java.home>/lib/rt.jar:kotlin-runtime.jar</java.home>

-keepclasseswithmembers public class * {
public static void main(java.lang.String[]);
}

-optimizationpasses 2 #NOTE that if value is 1 there is no problem at all

1 Attachments

Discussion

  • max-kammerer

    max-kammerer - 2016-06-02

    After 1 optimization pass i get:

      public static final void main(java.lang.String[]);
        descriptor: ([Ljava/lang/String;)V
        flags: ACC_PUBLIC, ACC_STATIC, ACC_FINAL
        Code:
          stack=3, locals=2, args_size=1
             0: aload_0
             1: ldc           #2                  // String args
             3: invokestatic  #14                 // Method kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull:(Ljava/lang/Object;Ljava/lang/String;)V
             6: aload_0
             7: iconst_0
             8: aaload
             9: dup
            10: ifnonnull     16
            13: invokestatic  #15                 // Method kotlin/jvm/internal/Intrinsics.throwNpe:()V
            16: aload_0
            17: iconst_1
            18: aaload
            19: astore_1
            20: dup
            21: astore_0
            22: aload_1
            23: ifnonnull     33
            26: ldc           #1                  // String
            28: swap
            29: pop
            30: goto          66
            33: aload_1
            34: astore_1
            35: dup
            36: astore_0
            37: ldc           #3                  // String s
            39: invokestatic  #14                 // Method kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull:(Ljava/lang/Object;Ljava/lang/String;)V
            42: aload_1
            43: ldc           #4                  // String z
            45: invokestatic  #14                 // Method kotlin/jvm/internal/Intrinsics.checkParameterIsNotNull:(Ljava/lang/Object;Ljava/lang/String;)V
            48: new           #9                  // class java/lang/StringBuilder
            51: dup
            52: invokespecial #11                 // Method java/lang/StringBuilder."<init>":()V
            55: aload_0
            56: invokevirtual #12                 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
            59: aload_1
            60: invokevirtual #12                 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
            63: invokevirtual #13                 // Method java/lang/StringBuilder.toString:()Ljava/lang/String;
            66: pop
            67: return
          StackMapTable: number_of_entries = 3
            frame_type = 80 /* same_locals_1_stack_item */
              stack = [ class java/lang/String ]
            frame_type = 255 /* full_frame */
              offset_delta = 16
              locals = [ top, class java/lang/String ]
              stack = [ class java/lang/String ]
            frame_type = 255 /* full_frame */
              offset_delta = 32
              locals = []
              stack = [ class java/lang/String ]
    
     
  • Eric Lafortune

    Eric Lafortune - 2016-06-12

    Thanks for your report. The attached class file seems to be truncated to 0 bytes. Could you attach or mail it again?

     
  • Eric Lafortune

    Eric Lafortune - 2016-06-12
    • assigned_to: Eric Lafortune
     
  • max-kammerer

    max-kammerer - 2016-06-14

    I attached class file and one more jared just in case

     

    Last edit: max-kammerer 2016-06-14
  • Eric Lafortune

    Eric Lafortune - 2016-06-26

    The bug was triggered by an unusual swap/pop construct in the bytecode. It should now be fixed for the upcoming ProGuard 5.3.

     

    Last edit: Eric Lafortune 2016-06-26
  • Eric Lafortune

    Eric Lafortune - 2016-06-26
    • status: open --> open-fixed
     
  • Kirill Rakhman

    Kirill Rakhman - 2016-08-11

    This fix doesn't seem to be available in the 5.3 Beta 1. Can I build the latest development version myself or get access to the fix any other way?

     
    • Eric Lafortune

      Eric Lafortune - 2016-08-11

      ProGuard 5.3 beta1 seems to solve this problem for me. Is this for the same class ElvisKt? Other classes may trigger the same error in very different ways.

       
      • Kirill Rakhman

        Kirill Rakhman - 2016-08-11

        The problem can be reproduced using the following repo: https://github.com/cypressious/KotlinProguardIssue/tree/d79f9ba8c97e335f504c88ea0c5171b22a10d4f7

        Just run gradlew assembleRelease

        The bytecode looks as follows:

          public final static doAsync(Ljava/lang/Object;Lkotlin/jvm/functions/Function1;)V
            @Lorg/jetbrains/annotations/Nullable;() // invisible, parameter 1
            TRYCATCHBLOCK L0 L1 L2 java/lang/Throwable
           L3
            LINENUMBER 7 L3
           L4
           L0
            NOP
           L5
            LINENUMBER 8 L5
            NOP
           L6
            GETSTATIC java/lang/System.out : Ljava/io/PrintStream;
            INVOKEVIRTUAL java/io/PrintStream.println ()V
           L7
           L8
           L1
            GOTO L9
           L2
            LINENUMBER 9 L2
            ASTORE 2
           L10
            LINENUMBER 10 L10
            ALOAD 1
            DUP
            IFNULL L11
            ALOAD 2
            INVOKEINTERFACE kotlin/jvm/functions/Function1.invoke (Ljava/lang/Object;)Ljava/lang/Object;
            CHECKCAST kotlin/Unit
            DUP
            IFNULL L11
            GOTO L12
           L11
            POP
            GETSTATIC kotlin/Unit.INSTANCE : Lkotlin/Unit;
           L12
            POP
           L13
            LINENUMBER 11 L13
           L9
            LINENUMBER 12 L9
            RETURN
           L14
            LOCALVARIABLE thr Ljava/lang/Throwable; L2 L13 2
            LOCALVARIABLE $receiver Ljava/lang/Object; L3 L14 0
            LOCALVARIABLE exceptionHandler Lkotlin/jvm/functions/Function1; L3 L14 1
            MAXSTACK = 2
            MAXLOCALS = 3
        

        I also attached the problematic class file. It was generated by the Kotlin compiler.

         

        Last edit: Kirill Rakhman 2016-08-11
        • Kirill Rakhman

          Kirill Rakhman - 2016-09-05

          5.3 beta2 seems to have fixed it.

           
          • Eric Lafortune

            Eric Lafortune - 2016-09-05

            Great, thanks for checking.

             
  • Eric Lafortune

    Eric Lafortune - 2016-10-23
    • Status: open-fixed --> closed-fixed
     

Log in to post a comment.